Skip to content

OpenCL now can run both sync/async gpu tests. #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rok-cesnovar merged 4 commits into from
Jul 3, 2020
Merged

OpenCL now can run both sync/async gpu tests. #1955

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f84043
OpenCL now can run both sync/async gpu tests.
serban-nicusor-toptal Jul 1, 2020
8ecaa0f
Fixed duplicate stage name
serban-nicusor-toptal Jul 1, 2020
27ab306
Updated opencl path
serban-nicusor-toptal Jul 1, 2020
a578d45
Fixed paths for opencl
serban-nicusor-toptal Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ def deleteDirWin() {
}

def skipRemainingStages = false
def runGpuAsync = false
def openClGpuLabel = "gpu"

def utils = new org.stan.Utils()

Expand All @@ -45,13 +47,10 @@ String stan_pr() { params.stan_pr ?: ( env.CHANGE_TARGET == "master" ? "downstre
pipeline {
agent none
parameters {
string(defaultValue: '', name: 'cmdstan_pr',
description: 'PR to test CmdStan upstream against e.g. PR-630')
string(defaultValue: '', name: 'stan_pr',
description: 'PR to test Stan upstream against e.g. PR-630')
booleanParam(defaultValue: false, description:
'Run additional distribution tests on RowVectors (takes 5x as long)',
name: 'withRowVector')
string(defaultValue: '', name: 'cmdstan_pr', description: 'PR to test CmdStan upstream against e.g. PR-630')
string(defaultValue: '', name: 'stan_pr', description: 'PR to test Stan upstream against e.g. PR-630')
booleanParam(defaultValue: false, name: 'withRowVector', description: 'Run additional distribution tests on RowVectors (takes 5x as long)')
booleanParam(defaultValue: false, name: 'gpu_async', description: 'Run the OpenCL tests on both a sync (AMD) GPU and an async (NVIDIA) one.')
}
options {
skipDefaultCheckout()
Expand Down Expand Up @@ -157,6 +156,14 @@ pipeline {

def paths = ['stan', 'make', 'lib', 'test', 'runTests.py', 'runChecks.py', 'makefile', 'Jenkinsfile', '.clang-format'].join(" ")
skipRemainingStages = utils.verifyChanges(paths)

if(!utils.verifyChanges(["stan/math/opencl", "test/unit/math/opencl"].join(" ")) || params.gpu_async){
runGpuAsync = true
openClGpuLabel = "gpu-no-async"
}
else{
runGpuAsync = false
}
}
}
}
Expand Down Expand Up @@ -222,7 +229,32 @@ pipeline {
post { always { retry(3) { deleteDir() } } }
}
stage('OpenCL tests') {
agent { label "gpu" }
agent { label openClGpuLabel }
steps {
deleteDir()
unstash 'MathSetup'
sh "echo CXX=${env.CXX} -Werror > make/local"
sh "echo STAN_OPENCL=true>> make/local"
sh "echo OPENCL_PLATFORM_ID=0>> make/local"
sh "echo OPENCL_DEVICE_ID=${OPENCL_DEVICE_ID}>> make/local"
sh "make -j${env.PARALLEL} test-headers"
runTests("test/unit/math/opencl")
runTests("test/unit/math/prim/fun/gp_exp_quad_cov_test")
runTests("test/unit/math/prim/fun/mdivide_left_tri_test")
runTests("test/unit/math/prim/fun/mdivide_right_tri_test")
runTests("test/unit/math/prim/fun/multiply_test")
runTests("test/unit/math/rev/fun/mdivide_left_tri_test")
runTests("test/unit/math/rev/fun/multiply_test")
}
post { always { retry(3) { deleteDir() } } }
}
stage('OpenCL tests async') {
agent { label "gpu-async" }
when {
expression {
runGpuAsync
}
}
steps {
deleteDir()
unstash 'MathSetup'
Expand Down