Add the CXX flag for only running rev tests with the test_ad#2630
Add the CXX flag for only running rev tests with the test_ad#2630rok-cesnovar merged 2 commits intodevelopfrom
Conversation
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
|
This is ready for review. It cuts about an hour from the Windows RTools 3.5 mix tests. |
SteveBronder
left a comment
There was a problem hiding this comment.
lgtm! As long as it's only used for windows testing I think it's fine. Though I think once we bump up the compiler version we test on we may want to think about turning this back off
|
Yes, once we bump, this should go away! |
Summary
This adds a CXX flag that can be used in Stan Math tests to not compile and run fwd & mix tests if the tests are using the test_ad utility.
I am primarily trying to add this so we can remove compiling & running fwd & mix tests with Windows and Rtools 3.5 (the tests that run with Github Actions). Particularly our mix tests are on the limit of what g++ 4.9.3 can handle, which is why we sometimes have to split tests files so that 4.9.3 can compile them.
I doubt anyone is using g++ 4.9.3 with fwd and mix. It is still used with Stan, but we only need rev tests to check compatibility there.
There is no Math issue for this PR. I can make one if needed.
Tests
This will decrease our testing with Windows Rtools 3.5 (
g++ 4.9.3). Given that we using g++ 4.9.3 outside of the use in Stan is not really recommended, I think this should be fine.Side Effects
/
Checklist
Copyright holder: Rok Češnovar
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)