Skip to content

Additional tests for complex overloads#2754

Merged
WardBrian merged 4 commits intodevelopfrom
feature/additional-complex-tests
Jun 15, 2022
Merged

Additional tests for complex overloads#2754
WardBrian merged 4 commits intodevelopfrom
feature/additional-complex-tests

Conversation

@WardBrian
Copy link
Copy Markdown
Member

Summary

PR #2753 allowed complex numbers to work with the SVD family of functions. Before exposing them to stanc, I decided to add extra tests. Truth values taken from numpy

Tests

Adds tests to singular_values, svd_U, and svd_V for a complex matrix input.

Side Effects

Added EXPECT_MATRIX_COMPLEX_FLOAT_EQ to test equality of complex-valued matrices.

Release notes

Checklist

  • Math issue : Related to Complex support for more linear algebra functions #2699

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Copy Markdown
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread test/unit/util.hpp
@WardBrian WardBrian merged commit 6e51096 into develop Jun 15, 2022
@WardBrian WardBrian deleted the feature/additional-complex-tests branch June 15, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants