Ensure proper cleanup during CI stage#2903
Merged
serban-nicusor-toptal merged 1 commit intodevelopfrom May 15, 2023
Merged
Conversation
serban-nicusor-toptal
added a commit
that referenced
this pull request
Jun 20, 2023
* creates a partials_propagator class to use instead of operands_and_partials for N-ary distributions * remove _impl from partials_propogation name and have maker function be make_partials_propogation * remove stan::math:: from edge calls * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * fix headers and add d() member to fvar * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * release/v4.6.0: updating version numbers (#2891) * Add overloads for complex multiply, testing workflow * Add comments, cpplint * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * Add additional overloads * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * Additional includes * Additional includes * Test revert 0verloads * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * release/v4.6.1: updating version numbers * Release/v4.6.1 (#2894) * release/v4.6.1: updating version numbers * add partials function as a little helper * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * add partials_vec helper function * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * Add tuple-returning QR decomposition * Use built-in concurrency feature in Github Actions * Dummy change to force cancellation * Also update header checks * Fixup ops_partials_edge for fvar * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * Add necessary overloads for Tuple return types in expression tests * [Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1 * Ensure cleanup after Verify Changes stage (#2903) * release/v4.6.2: updating version numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Because we do not clean after
VerifyChangesmaster is keeping an older state on disk, this PR fixes this behavior.Tests
Side Effects
Release notes
Checklist
Math issue #(issue number)
Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested