fix merge conflicts for rvar_weights #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence update psis paper reference
Validate weights fix
Pareto k tail fix
update psis ref journal info
type check assertions for rvar draws, closes stan-dev#363
…he-version Update workflow actions
Add behaviour to the function in the corner cases of infinite values or empty input.
Update log_sum_exp
Add pit functions
properly take into account r_eff when deciding tail length
merge latest changes to rvar_weights branch
Collaborator
|
Thank you! Is this ready to merge from your side? |
Collaborator
Author
|
I think so, perhaps further review could be made before the actual merge to master, but this PR should be good to go now |
Collaborator
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes all merge conflicts between master and rvar_weights branches. Some adjustments were made to make sure all checks/tests were ok.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: