This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Handle unsigned integers in data#333
Merged
ariddell merged 1 commit intostan-dev:developfrom May 1, 2017
ariddell:feature/issue-303
Merged
Handle unsigned integers in data#333ariddell merged 1 commit intostan-dev:developfrom ariddell:feature/issue-303
ariddell merged 1 commit intostan-dev:developfrom
ariddell:feature/issue-303
Conversation
_split_data now handles unsigned integers (e.g., numpy.uint8) by converting them into integers. Thanks to @tyarkoni for the report and @ahartikainen for the suggested fix. Closes #303
Contributor
Author
|
CI tests pass, hit a timeout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_split_data now handles unsigned integers (e.g., numpy.uint8)
by converting them into integers.
Thanks to @tyarkoni for the report and @ahartikainen for the suggested
fix.
Closes #303