Fix inconsistency in whether locations are opaque in sexps#1547
Merged
Fix inconsistency in whether locations are opaque in sexps#1547
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
+ Coverage 90.09% 90.14% +0.05%
==========================================
Files 64 64
Lines 9861 9855 -6
==========================================
Hits 8884 8884
+ Misses 977 971 -6
🚀 New features to boost your workflow:
|
nhuurre
reviewed
Sep 11, 2025
Comment on lines
117
to
+119
| | LTuplePack of | ||
| { lvals: 'l lvalue_pack list | ||
| ; loc: Location_span.t [@sexp.opaque] [@compare.ignore] } | ||
| ; loc: (Location_span.t[@sexp.opaque] [@compare.ignore]) } |
Collaborator
There was a problem hiding this comment.
I didn't find a related test. What does this do exactly?
Member
Author
There was a problem hiding this comment.
I just added an extra Parse_test -- removing the parenthesis will change the output of this new test to include the location, rather than omit <opaque> as elsewhere.
I couldn't find much about the fact that these annotations for deriving are so sensitive, but it seems like they're ignored if they're not precisely as expected, meaning it's easy to miss
nhuurre
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mostly a simple case of some missing parenthesis changing the meaning of annotations, or annotations being misnamed.
Submission Checklist
Release notes
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)