Add missing (container, real, real) overloads for contraint functions#1589
Merged
Add missing (container, real, real) overloads for contraint functions#1589
Conversation
WardBrian
force-pushed
the
missing-constraint-signatures
branch
from
c3738a0 to
65540ee
Compare
Contributor
|
Little confused, should these be generating changes to the cpp files in the integration test folder? |
Member
Author
|
No, we don’t store the output of all those function-signatures tests, Jenkins just makes sure they compile and link |
SteveBronder
approved these changes
Feb 23, 2026
Contributor
SteveBronder
left a comment
SteveBronder
left a comment
There was a problem hiding this comment.
In that case I say good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported here: https://discourse.mc-stan.org/t/missing-signatures-for-jacobian-and-constrain-functions/40934
Submission Checklist
Release notes
Added some missing overloads to the
upper_lowerandoffset_multiplierconstraint functions.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)