Expose DiffusionGrid buffers via protected accessors; migrate Euler grids off friend pattern#7
Open
Expose DiffusionGrid buffers via protected accessors; migrate Euler grids off friend pattern#7
Conversation
Adds four protected accessors on DiffusionGrid:
- GetConcentrationPtr / GetScratchPtr : mutable pointers to the live and
scratch concentration buffers
- SwapBuffers : swap the live and scratch buffers at the end of a step
- GetRawDiffusionCoefficient : returns D directly (the stored dc_[0] is
1 - D for stencil convenience)
Lets solver subclasses implement their own Diffuse* methods without
requiring a friend declaration on DiffusionGrid.
Each Diffuse* method hoists local aliases at the top and the loops use those aliases. Mechanical rewrite: c1_[i] -> c1[i], mu_ -> mu, c1_.swap(c2_) -> SwapBuffers(), boundary_condition_->Evaluate(...) -> GetBoundaryCondition()->Evaluate(...). Stencil and loop structure are unchanged. With no subclass reaching into private members, the EulerGrid and EulerDepletionGrid friend declarations are removed. Existing diffusion and euler tests still pass.
4 tasks
stanbot8
force-pushed
the
refactor/diffusion-grid-accessors
branch
2 times, most recently
from
a6346b3 to
417067b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffusionGrid(GetConcentrationPtr,GetScratchPtr,SwapBuffers,GetRawDiffusionCoefficient) so solver subclasses don't need a friend declaration.EulerGridandEulerDepletionGridmigrated to the new accessors. Their friend decls onDiffusionGridare dropped; onlyTestGridremains.Test plan
-Dnuma=offfor WSL)