fix: insert column/row buttons not working#39
Conversation
|
Actually, the previous code tried to insert the column/row AND increase the column/row by one. So far, this PR has the following features/fixes:
|
|
Hi Johnny, Hope all is well! A year ago I had messed with fixing this and I believe I had a working solution which I have up here on a commit: bryvin@3648c17 Maybe this can be of some help, it's a bit hacky but with the way KendoUI loads/renders the spreadsheets it was a little difficult to adjust the size after it had been rendered. So hijacking the render call after using one of the built in events to insert a row/column and triggering a fresh build of the sheet from the JSON data on the next render with the new size seemed to have fixed it. |
|
Hi @bryvin! Thanks for letting me know about your fix, it's working great so far! |
|
I was under the impression this wasn't originally merged back in January due to all undo history being removed when rebuilding the sheet after inserting/removing rows and columns. Was that fixed at all? |
|
Hey @bryvin, before version 1.3.7, the undo/redo buttons did not work after inserting/removing columns or rows. So merging this PR will not break anything. |
|
Ah, perfect then! Glad you got this in :) |
Fixes #12 and standardnotes/forum#386