Skip to content

fix: insert column/row buttons not working#39

Merged
johnny243 merged 6 commits into
mainfrom
fix-insert-column-row
Jun 11, 2021
Merged

fix: insert column/row buttons not working#39
johnny243 merged 6 commits into
mainfrom
fix-insert-column-row

Conversation

@johnny243
Copy link
Copy Markdown
Contributor

@johnny243 johnny243 requested a review from atmoio January 10, 2021 22:01
@johnny243 johnny243 marked this pull request as draft January 10, 2021 22:06
@johnny243
Copy link
Copy Markdown
Contributor Author

johnny243 commented Jan 11, 2021

Actually, the previous code tried to insert the column/row AND increase the column/row by one.


So far, this PR has the following features/fixes:

  • ability to use the insert column/row buttons
  • when inserting columns/rows, the columns/rows number should be increased

@bryvin
Copy link
Copy Markdown
Contributor

bryvin commented Jan 12, 2021

Hi Johnny,

Hope all is well! A year ago I had messed with fixing this and I believe I had a working solution which I have up here on a commit: bryvin@3648c17

Maybe this can be of some help, it's a bit hacky but with the way KendoUI loads/renders the spreadsheets it was a little difficult to adjust the size after it had been rendered. So hijacking the render call after using one of the built in events to insert a row/column and triggering a fresh build of the sheet from the JSON data on the next render with the new size seemed to have fixed it.

@johnny243
Copy link
Copy Markdown
Contributor Author

Hi @bryvin!

Thanks for letting me know about your fix, it's working great so far!

@johnny243 johnny243 marked this pull request as ready for review January 13, 2021 00:37
@johnny243 johnny243 requested review from atmoio and removed request for atmoio January 13, 2021 16:46
@johnny243 johnny243 changed the base branch from master to main February 22, 2021 01:35
@johnny243 johnny243 merged commit 00cbf5c into main Jun 11, 2021
@johnny243 johnny243 deleted the fix-insert-column-row branch June 11, 2021 14:05
@bryvin
Copy link
Copy Markdown
Contributor

bryvin commented Jun 11, 2021

I was under the impression this wasn't originally merged back in January due to all undo history being removed when rebuilding the sheet after inserting/removing rows and columns. Was that fixed at all?

@johnny243
Copy link
Copy Markdown
Contributor Author

johnny243 commented Jun 11, 2021

Hey @bryvin, before version 1.3.7, the undo/redo buttons did not work after inserting/removing columns or rows. So merging this PR will not break anything.

@bryvin
Copy link
Copy Markdown
Contributor

bryvin commented Jun 11, 2021

Ah, perfect then! Glad you got this in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inserting row/column only inserts at the end of the rows or columns

2 participants