Conversation
| return '2.7.23'; | ||
| } | ||
|
|
||
| protected registerStageHandlers(): void { |
There was a problem hiding this comment.
Sign in event is only on explicit sign in. And actually you don’t have to be signed in to have a repo. This should be on full sync completed instead.
There was a problem hiding this comment.
But we need a user uuid to be able to update the user setting
There was a problem hiding this comment.
Ah ok, in that case on full sync completed and if signed in.
|
Is this testable? |
It should be, let me give it a try 🙂 |
antsgar
force-pushed
the
feature/extension-key-migration
branch
from
32672f8 to
be40b51
Compare
antsgar
changed the base branch from
master
to
feature/features-instead-of-permissions
|
@mobitar added the extension repo items observer, but I suppose we should still keep the migration for already existing items? |
…xtension-key-migration
|
Depends on #385 since the observer has been added to the new features service |
karolsojko
left a comment
karolsojko
left a comment
There was a problem hiding this comment.
Good stuff - glad to know we have these kind of mechanisms in place 👍
|
Closing in favor of #394 (PR shows wrong commits after dependent PR was squash-merged) |
3 participants
No description provided.