This repository was archived by the owner on Jul 6, 2022. It is now read-only.
Conversation
gorjan5sk
force-pushed
the
feature/mfa-service
branch
2 times, most recently
from
d787527 to
fe1cf6f
Compare
gorjan5sk
force-pushed
the
feature/mfa-service
branch
from
02d6c10 to
4b5b304
Compare
karolsojko
reviewed
Aug 26, 2021
antsgar
reviewed
Aug 26, 2021
| })); | ||
| await new Promise(resolve => setTimeout(resolve, 1000)); | ||
| expect(await application.getSetting(SettingName.ExtensionKey)).toBe(extensionKey); | ||
| expect(await application.getSetting(SettingName.ExtensionKey)).toBe(null); |
Contributor
There was a problem hiding this comment.
Not following, if the setting is null then it means it hasn't been updated with the right key?
antsgar
approved these changes
Aug 26, 2021
johnny243
reviewed
Aug 26, 2021
Co-authored-by: Johnny A. <5891646+johnny243@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented SNMfaService leveraging SNSettingsService with sensitive settings, the API exposes: