Skip to content

fix: file list item icon alignment #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanharwara merged 4 commits into from
May 23, 2022
Merged

fix: file list item icon alignment #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00f33a7
fix: file list item icon alignment
amanharwara May 23, 2022
8875415
feat: add new utility class
amanharwara May 23, 2022
7c26166
feat: remove obsolete css class
amanharwara May 23, 2022
478f2e7
Merge branch 'develop' into fix/file-item-icon
amanharwara May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascripts/Components/ContentListView/FileListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const FileListItem: FunctionComponent<DisplayableListItemProps> = observe
}}
>
{!hideIcon ? (
<div className="flex flex-col items-center justify-between p-4 pr-3 mr-0">
<div className="flex flex-col items-center justify-between p-4.5 pr-3 mr-0">
<IconComponent />
</div>
) : (
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/Components/NoAccountWarning/NoAccountWarning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const NoAccountWarning = observer(({ appState }: Props) => {
}, [appState])

return (
<div className="mt-5 p-5 rounded-md shadow-sm grid grid-template-cols-1fr">
<div className="mt-5 p-4 rounded-md shadow-sm grid grid-template-cols-1fr">
<h1 className="sk-h3 m-0 font-semibold">Data not backed up</h1>
<p className="m-0 mt-1 col-start-1 col-end-3">Sign in or register to back up your notes.</p>
<button className="sn-button small info mt-3 col-start-1 col-end-3 justify-self-start" onClick={showAccountMenu}>
Expand Down
4 changes: 4 additions & 0 deletions app/assets/stylesheets/_sn.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,10 @@
padding: 1rem;
}

.p-4\.5 {
padding: 1.125rem;
}

.p-6 {
padding: 1.5rem;
}
Expand Down
3 changes: 0 additions & 3 deletions app/assets/stylesheets/_ui.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,6 @@ $screen-md-max: ($screen-lg-min - 1) !default;
.p-4 {
padding: 0.8125rem;
}
.p-5 {
padding: 1.015625rem;
}

.pt-0 {
padding-top: 0;
Expand Down