Skip to content

feat: add prefs button to navigation panel on mobile #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanharwara merged 3 commits into from
Sep 23, 2022
Merged

feat: add prefs button to navigation panel on mobile #1625

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ddf589
feat: add prefs button to navigation panel on mobile
amanharwara Sep 23, 2022
78337eb
fix: use themes icon
amanharwara Sep 23, 2022
b3363ed
Merge branch 'main' into feat/nav-prefs
amanharwara Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/web/src/javascripts/Components/Navigation/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,16 @@ const Navigation: FunctionComponent<Props> = ({ application }) => {
<Icon type="lock-filled" size="custom" className="h-4.5 w-4.5" />
</button>
)}
<button
className="ml-2.5 flex h-8 min-w-8 cursor-pointer items-center justify-center rounded-full border border-solid border-border bg-default text-neutral hover:bg-contrast focus:bg-contrast"
onClick={() => {
viewControllerManager.preferencesController.openPreferences()
}}
title="Go to preferences"
aria-label="Go to preferences"
>
<Icon type="tune" />
</button>
<button
className="ml-2.5 flex h-8 min-w-8 cursor-pointer items-center justify-center rounded-full border border-solid border-border bg-default text-neutral hover:bg-contrast focus:bg-contrast"
onClick={() => {
Expand All @@ -124,7 +134,7 @@ const Navigation: FunctionComponent<Props> = ({ application }) => {
title="Go to quick settings menu"
aria-label="Go to quick settings menu"
>
<Icon type="tune" />
<Icon type="themes" />
</button>
</div>
</ResponsivePaneContent>
Expand Down