Skip to content

Disconnect between inline comment and removed extended rule configs? #102

@mjankowski

Description

@mjankowski

I had opened #98 right at same time as the other PR which handled same issue. That PR just merged, so mine closed, which makes sense. Glad the noise thing is handled.

Pulling a maybe still relevant thought out of there -- there's some small inconsistency with the comment here - https://github.com/standardrb/standard-rails/blob/main/lib/standard/rails/plugin.rb#L47-L61 - and the rules and the history of that whole thing. The comment says standard does not enable these cops

The commit which added this "without extended" - acccb02 - removed Lint/RedundantSafeNavigation and Style/InvertibleUnlessCondition from the base config, but then adds Style/InvertibleUnlessCondition and Lint/SafeNavigationChain to this reject line ... should that latter addition have actually been Lint/RedundantSafeNavigation (to match what was removed), and/or should they all be there? Maybe I'm misunderstanding something about the comment or rule loading.

At minimum, does the comment need an update to make the "doesnt enable" portion more accurate?

I realize this is sort of nit picky and (I think) there's no broken behavior, just highlighting something which briefly confused me on the other PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions