[audit] fix: foldmethod "indent" → "expr" to activate treesitter folding#153
Merged
Conversation
…expr foldexpr was set to vim.treesitter.foldexpr() but foldmethod was still "indent", so the treesitter fold expression was never evaluated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lua/config/options.lua:100setsfoldmethod = "indent"but the very next line configures a treesitterfoldexpr. Because Neovim only evaluatesfoldexprwhenfoldmethod = "expr", the treesitter fold expression has been silently dead — folding was indent-based all along.Where
lua/config/options.lua:100Why it matters
With
foldmethod = "indent", folds are purely whitespace-based and have no awareness of language syntax — mismatched indentation (e.g. Python docstrings, closing braces) creates wrong fold boundaries.foldmethod = "expr"withvim.treesitter.foldexpr()uses the AST for correct, language-aware fold boundaries.foldlevel = 10is already set, so switching to"expr"will not collapse any currently-open folds — behaviour is identical on startup, but:set foldmethod?will now reportexprandzc/zawill fold on correct AST boundaries.Note on
foldnestmaxfoldnestmaxonly applies toindentandsyntaxmethods; it is silently ignored byexpr. The existingvim.o.foldnestmax = 10line becomes a harmless no-op after this change.Recommended action
Merge. One-line change, zero risk of breaking existing open-fold behaviour.
Generated by Claude Code