Add num_retries to signature_opt_typed
#1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `num_retries` option to `signature_opt_typed.optimize_signature()`. This is passed through to both `TypedChainOfThought` and `TypedPredictor`. **Why?** Because I was stuck. I kept getting this error message: > Value error, Never propose a signature already in the list above.: proposed_signature (error type: value_error) I can get around this error by raising the model's temperature as well as setting this to `num_retries=10`. Note: I see comments about not supporting temperature because it breaks parsing. While that's true, having temp be zero also leads to getting completely stuck because there's no simple solution for common errors like this. With high enough temperature and enough retries, I should be able to unstick myself from any situation.
Collaborator
|
Thank you @tkellogg ! This looks like a very useful addition to me but I'll defer to @thomasahle if he has a chance to check, since he built all the typed pieces. Will merge in 2 days otherwise. |
Collaborator
|
and +1 to "Why? Because I was stuck." We need more such PRs. |
This adds a `num_retries` option to `signature_opt_typed.optimize_signature()`. This is passed through to both `TypedChainOfThought` and `TypedPredictor`. **Why?** Because I was stuck. I kept getting this error message: > Value error, Never propose a signature already in the list above.: proposed_signature (error type: value_error) I can get around this error by raising the model's temperature as well as setting this to `num_retries=10`. Note: I see comments about not supporting temperature because it breaks parsing. While that's true, having temp be zero also leads to getting completely stuck because there's no simple solution for common errors like this. With high enough temperature and enough retries, I should be able to unstick myself from any situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
num_retriesoption tosignature_opt_typed.optimize_signature(). This is passed through to bothTypedChainOfThoughtandTypedPredictor.Why? Because I was stuck. I kept getting this error message:
I can get around this error by raising the model's temperature as well as setting this to
num_retries=10.Note: I see comments about not supporting temperature because it breaks parsing. While that's true, having temp be zero also leads to getting completely stuck because there's no simple solution for common errors like this. With high enough temperature and enough retries, I should be able to unstick myself from any situation.