updated assertions error msg to specify target_module #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhat
reviewed
Oct 7, 2024
| dspy.Suggest( | ||
| len(query) <= 100, | ||
| "Query should be short and less than 100 characters", | ||
| target_module=self.generate_query |
Collaborator
There was a problem hiding this comment.
Wait I don't think we want the examples to be verbose like this. It's nice that they were implicit some of the time.
okhat
reviewed
Oct 7, 2024
dspy/primitives/assertions.py
Outdated
|
|
||
| if dspy.settings.backtrack_to is None: | ||
| dspy.logger.error("Specified module not found in trace") | ||
| dspy.logger.error("Module not found in trace. If passing a DSPy Signature, please specify the intended module for the assertion (e.g., use `dspy.ChainOfThought(GenerateAnswer)` instead of `GenerateAnswer`).") |
Collaborator
There was a problem hiding this comment.
The error is good except the example, I think you wanna say use self.my_module. With the current error, people may pass a new object of dspy.ChainOfThought literally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.