Refactor finetuning implementation to be 2.5 compatible #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhat
reviewed
Oct 17, 2024
okhat
reviewed
Oct 17, 2024
okhat
reviewed
Oct 17, 2024
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
Nice work!
Agreed with @okhat, the PR can use some refactoring to have the finetuning code in a standalone mode.
dspy/predict/predict.py
Outdated
| def assert_structural_equivalency_for_predictors( | ||
| predictor1: object, | ||
| predictor2: object, | ||
| ) -> Optional[AssertionError]: |
Collaborator
There was a problem hiding this comment.
Yes this type hint is a bit confusing, we can omit the type hints here.
chenmoneygithub
requested changes
Oct 17, 2024
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
Thanks for the update! Most comments are on nits.
Collaborator
|
Besides the things discussed on Slack, this is good to merge except for |
Collaborator
|
Incredible work on this @dilarasoylu & @isaacbmiller !! |
dilarasoylu
force-pushed
the
dev_finetune
branch
from
4eb4f09 to
347e1a4
Compare
dilarasoylu
force-pushed
the
dev_finetune
branch
from
347e1a4 to
1eb95ce
Compare
okhat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dilarasoylu
relevant anysacle notebook is anyscale/templates#381