Fix the saving of TypePredictor #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireking77
reviewed
Oct 20, 2024
| def signature(self) -> dspy.Signature: | ||
| return self.predictor.signature | ||
|
|
||
| @signature.setter |
There was a problem hiding this comment.
If you want to ensure that this value is not set outside the object initialization (bootstrapping), I would remove the setter to prevent anyone from using it to set the value. Of course, the tests should still pass.
In summary, if you don't plan to use it, the setter is unnecessary.
Collaborator
Author
There was a problem hiding this comment.
Unfortunately we have to keep self.signature being readable and settable, otherwise it could break people's existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1644
We don't need a standalone signature attribute in
TypePredictor, because it's never actually used. We keep theself.signatureto be valid for backward compatibility