Some minor fixes to the newly introduced callback #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
force-pushed
the
fix-callback
branch
2 times, most recently
from
2542d5d to
3e49687
Compare
chenmoneygithub
commented
Oct 25, 2024
| import litellm | ||
| from litellm.caching import Cache | ||
|
|
||
| from dspy.utils.logging import logger |
Collaborator
Author
There was a problem hiding this comment.
Sorted the imports.
chenmoneygithub
force-pushed
the
fix-callback
branch
from
3e49687 to
9defca7
Compare
omrirh
pushed a commit
to omrirh/dspy
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to callbacks for better readability and usability, including:
adapterin the name for clarity, ason_parse_startis a bit ambiguous.