Skip to content

Conversation

@GuyAglionby
Copy link

Previously, using HFClientTGI with BootstrapFewShot didn't work for max_rounds > 1. The culprit was:

File "<snip>/lib/python3.10/site-packages/dsp/modules/lm.py", line 84, in copy
    model = kwargs.pop('model')
KeyError: 'model'

This PR makes sure the relevant kwargs are saved (all are necessary)

Thanks!

@darinkishore
Copy link
Collaborator

@okhat if this PR could be reviewed and merged would be amazing :)

@janpf
Copy link

janpf commented Feb 4, 2024

Same issue for OllamaLocal(LM), but just saving it to kwargs messes with the copy function of the LM class.

@arnavsinghvi11 arnavsinghvi11 merged commit 6d8968a into stanfordnlp:main Apr 13, 2024
@arnavsinghvi11
Copy link
Collaborator

Thanks @GuyAglionby ! just following up on old PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants