Skip to content

Conversation

@Timtech4u
Copy link
Contributor

@Timtech4u Timtech4u commented Jan 20, 2025

The changes introduce multitenancy support to the WeaviateRM class. A new optional parameter tenant_id is added to the constructor, allowing the user to specify a tenant ID. This tenant ID can also be provided as a keyword argument during query execution. When a tenant ID is specified, all retrieval requests are scoped to the given tenant ID, ensuring tenant-specific data access within a multitenant Weaviate instance.

@okhat okhat requested a review from CShorten February 3, 2025 11:28
@okhat
Copy link
Collaborator

okhat commented Feb 3, 2025

Thanks @Timtech4u ! Requesting review from @CShorten if he has a minute :D

@CShorten
Copy link
Collaborator

CShorten commented Feb 4, 2025

Thanks so much for adding this @Timtech4u and the tag @okhat!

Approved!

Made a few small changes:

Caught one missing .with_tenant and added two documentation comments explaining the tenant_id constructor argument and a general blurb about what Multi-Tenancy is.

=== Broader Comments ===

Going forward I don't think this is the best pattern for Multi-Tenancy and DSPy Modules in Production -- probably better to pass tenant_id in the forward pass versus as internal state to the Module. This looks good for now, but will keep an eye on this as it evolves.

cc @hsm207

@Timtech4u
Copy link
Contributor Author

Amazing! Thank you @CShorten

@okhat okhat merged commit 10fe155 into stanfordnlp:main Feb 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants