Skip to content

Style fix for base adapter #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Style fix for base adapter #7849

merged 1 commit into from
Feb 25, 2025

Conversation

@chenmoneygithub
Copy link
Collaborator

@chenmoneygithub chenmoneygithub commented Feb 25, 2025

Style fix in order to enable style check:

  1. no relative imports
  2. explicitly raise error instead of using assert
  3. Better error message
  4. indent correctly

@chenmoneygithub chenmoneygithub merged commit 996ea4e into stanfordnlp:main Feb 25, 2025
4 checks passed
@chenmoneygithub chenmoneygithub deleted the style-fix-chatadapter branch April 25, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chenmoneygithub