Skip to content

Conversation

@chenmoneygithub
Copy link
Collaborator

@chenmoneygithub chenmoneygithub commented Mar 12, 2025

We can remove .prettierignore to keep our top level clean, but we need to fix the lint issue of github workflows first. This PR only fixes the lint, and the actual removal will happen in the next PR.

@chenmoneygithub chenmoneygithub requested a review from okhat March 12, 2025 01:12
@okhat
Copy link
Collaborator

okhat commented Mar 12, 2025

@hmoazam thoughts?

@chenmoneygithub chenmoneygithub requested a review from hmoazam March 12, 2025 01:15
@hmoazam
Copy link
Collaborator

hmoazam commented Mar 12, 2025

So the reason for that was that the release workflow throws an error about not being able to modify the workflows themselves. It turned out this was due to prettify formatting the workflows. So in general yes we can remove this, but it will mean any time we edit any of the workflows, we will have to ensure they follow prettify standards locally otherwise the workflows will break.

@okhat
Copy link
Collaborator

okhat commented Mar 12, 2025

thank you Hanna,,, ok @chenmoneygithub thoughts?

@chenmoneygithub
Copy link
Collaborator Author

release workflow throws an error about not being able to modify the workflows themselves

@hmoazam Hmm I am not following this, I don't see the release workflow modifies the yml file, was it in an older version?

@chenmoneygithub chenmoneygithub changed the title Remove .prettierignore and fix lint problems of workflows Fix lint problems of workflows so that we can remove .prettierignore in the future Mar 17, 2025
@chenmoneygithub
Copy link
Collaborator Author

@hmoazam I am reverting the removal of .prettierignore in this PR, when you get back, we can check again why it caused error in earlier release.

@chenmoneygithub chenmoneygithub merged commit 5cc3dcb into stanfordnlp:main Mar 17, 2025
4 checks passed
@chenmoneygithub chenmoneygithub deleted the fix-workflow-unintendd branch April 25, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants