Disable editing of Notes Directory in settings#67
Conversation
69325ba to
86dffb7
Compare
Co-authored-by: stanleygomes <5298153+stanleygomes@users.noreply.github.com>
Co-authored-by: stanleygomes <5298153+stanleygomes@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Disables the Notes Directory text field in the settings UI to prevent users from changing the notes storage path, avoiding potential file-loss scenarios.
Changes:
- Disabled the
notesDirectoryFieldinNotesConfigFormComponentby settingisEnabled = false - Added a unit test to verify the field is disabled after form construction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
NotesConfigFormComponent.kt |
Sets isEnabled = false on the notes directory text field |
NotesConfigFormComponentTest.kt |
New test asserting the directory field is disabled |
86dffb7 to
6978625
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 40.01% 45.48% +5.47%
==========================================
Files 98 98
Lines 1537 1539 +2
Branches 189 189
==========================================
+ Hits 615 700 +85
+ Misses 901 818 -83
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.1.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Users need to see where notes are stored but should not be able to change that path for now, to avoid file-loss scenarios from directory changes. This PR keeps the setting visible while making the directory field non-editable.
Settings UI behavior
NotesConfigFormComponentto render the Notes Directory text field as disabled.Targeted coverage
NotesConfigFormComponentTestto assert the notes directory field is disabled after form construction.Implementation snippet
Screenshot
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.jetbrains.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.