Skip to content

build: Use UI library, remove unused stuff#1

Closed
stanleyjones wants to merge 2 commits intomainfrom
remove-unused
Closed

build: Use UI library, remove unused stuff#1
stanleyjones wants to merge 2 commits intomainfrom
remove-unused

Conversation

@stanleyjones
Copy link
Copy Markdown
Owner

Description

This PR is a continuation of the efforts begun in liftedinit/gwen#13 and liftedinit/kaylee#4 to move all of our apps to a shared UI library.

  • Replace all imports from shared/* to @liftedinit/ui
  • Copy components that rely on local state (i.e. AssetSelector, Layout) out of shared directory
  • Remove unused directories (i.e. src/shared/ and /src/features/auth)
  • Streamline package.json (remove unused packages, move devDependencies to the correct place)

Testing / Breaking Changes

Build, unit tests, and e2e tests all pass. Visually inspected manually (and made a couple changes).

There should be no breaking changes.

Screenshots

BEFORE

Screenshot 2022-12-06 at 3 39 51 PM

AFTER

Screenshot 2022-12-06 at 3 40 06 PM

You may notice that this PR changes the default font from Roboto back to Rubik. This change is intended.

@stanleyjones stanleyjones self-assigned this Dec 6, 2022
@stanleyjones
Copy link
Copy Markdown
Owner Author

Wrong base repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant