This repository was archived by the owner on Jan 3, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added mono binaries/includes - Basic assembly loading and object creation/method calling in ScriptEngine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions workflow to install a specific version of the Vulkan SDK and adjusts the build configuration and artifact paths.
- Adds a step to install the Vulkan SDK with specific version and components.
- Updates the MSBuild command to use a "Dist" configuration and changes the artifact upload paths accordingly.
Files not reviewed (7)
- Dependencies.lua: Language not supported
- StarEditor/imgui.ini: Language not supported
- StarEditor/mono/lib/mono/4.5/MSBuild/Microsoft.Build.Core.xsd: Language not supported
- StarEditor/mono/lib/mono/4.5/Microsoft.Build.xsd: Language not supported
- StarEditor/mono/lib/mono/4.5/Microsoft.CSharp.targets: Language not supported
- StarEditor/mono/lib/mono/4.5/Microsoft.Common.tasks: Language not supported
- StarEditor/mono/lib/mono/4.5/Microsoft.VisualBasic.targets: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/main.yml:49
- Verify that the 'stripdown' parameter is supported by the 'jakoch/install-vulkan-sdk-action@v1.2.0' action. If this is a typo or an unsupported option, correct it to avoid installation issues.
stripdown: true
.github/workflows/main.yml:65
- Changing the build configuration from Debug to Dist is a significant change; confirm that this update aligns with the intended deployment pipeline and that any dependent scripts or tests are updated accordingly.
run: MSBuild /m /p:Configuration=Dist StarEngine.sln
.github/workflows/main.yml:73
- Ensure that the revised artifact paths correctly reflect the output structure after switching to the 'Dist' configuration.
bin/Dist-windows-x86_64/StarEditor/assets
The beginning
- big refactored - added component and stuff like that
- StarEngine-ScriptCore is the "core" scripting library
- Also getting/setting values during runtime
- Fixed some warnings in SceneHierarchyPanel - Added Scene::IsRunning
- Also changed viewport events to block when mouse isn't hovering over, even if focused - Scenes loaded on StarEditor startup via command line args now follow proper code path - "Experimentally" disabled setting viewport size on scene load - Renamed all rigidbody things with caps on, so no errors
- Also fixed scene viewport not always getting resized
…es + Reload Assembly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.