Skip to content
This repository was archived by the owner on Jan 3, 2026. It is now read-only.

Conversation

@sheazywi
Copy link
Member

No description provided.

Pier-Olivier Boulianne added 3 commits March 28, 2025 15:17
- Added mono binaries/includes
- Basic assembly loading and object creation/method calling in ScriptEngine
@sheazywi sheazywi added the enhancement New feature or request label Mar 28, 2025
@sheazywi sheazywi requested a review from Copilot March 28, 2025 21:09
@sheazywi sheazywi self-assigned this Mar 28, 2025
@sheazywi sheazywi moved this to In Progress in StarEngine Project Roadmap Mar 28, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow to install a specific version of the Vulkan SDK and adjusts the build configuration and artifact paths.

  • Adds a step to install the Vulkan SDK with specific version and components.
  • Updates the MSBuild command to use a "Dist" configuration and changes the artifact upload paths accordingly.
Files not reviewed (7)
  • Dependencies.lua: Language not supported
  • StarEditor/imgui.ini: Language not supported
  • StarEditor/mono/lib/mono/4.5/MSBuild/Microsoft.Build.Core.xsd: Language not supported
  • StarEditor/mono/lib/mono/4.5/Microsoft.Build.xsd: Language not supported
  • StarEditor/mono/lib/mono/4.5/Microsoft.CSharp.targets: Language not supported
  • StarEditor/mono/lib/mono/4.5/Microsoft.Common.tasks: Language not supported
  • StarEditor/mono/lib/mono/4.5/Microsoft.VisualBasic.targets: Language not supported
Comments suppressed due to low confidence (3)

.github/workflows/main.yml:49

  • Verify that the 'stripdown' parameter is supported by the 'jakoch/install-vulkan-sdk-action@v1.2.0' action. If this is a typo or an unsupported option, correct it to avoid installation issues.
          stripdown: true

.github/workflows/main.yml:65

  • Changing the build configuration from Debug to Dist is a significant change; confirm that this update aligns with the intended deployment pipeline and that any dependent scripts or tests are updated accordingly.
        run: MSBuild /m /p:Configuration=Dist StarEngine.sln

.github/workflows/main.yml:73

  • Ensure that the revised artifact paths correctly reflect the output structure after switching to the 'Dist' configuration.
            bin/Dist-windows-x86_64/StarEditor/assets

Pier-Olivier Boulianne added 9 commits April 19, 2025 22:31
- Fixed some warnings in SceneHierarchyPanel
- Added Scene::IsRunning
- Also changed viewport events to block when mouse isn't hovering over, even if focused
- Scenes loaded on StarEditor startup via command line args now follow proper code path
- "Experimentally" disabled setting viewport size on scene load
- Renamed all rigidbody things with caps on, so no errors
- Also fixed scene viewport not always getting resized
@sheazywi sheazywi merged commit b0dbc95 into main Apr 26, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in StarEngine Project Roadmap Apr 26, 2025
@sheazywi sheazywi deleted the csharp branch May 24, 2025 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants