Issue 15#16
Merged
stardothosting merged 6 commits intomainfrom Jun 30, 2025
Merged
Conversation
- Implement multi-attempt strategy: quick fetch (30s, 5 pages) then full fetch (45s, 10 pages) - Add smart retry logic that only retries on timeout errors - Improve error messages with detailed explanations and actionable advice - Enhanced logging with attempt details and duration tracking - Better differentiation between timeout vs other API errors This addresses the recurring 'cURL error 28' timeouts from Unwrangle API and provides users with clearer feedback when requests fail.
- Set timeouts to 60s, 90s, 120s with progressive page limits - Add connectivity test before API calls - Better HTTP client configuration with proper headers - Categorize errors for easier debugging - Skip connectivity test during testing
- Add API_TIMEOUT and CONNECTIVITY_ISSUE alert types - Integrate timeout alerts into AmazonFetchService - Send alerts for connection timeouts and connectivity failures - Add throttling (15-30 min) to prevent alert spam - Create test command for timeout alerts
- Updated LoggingServiceTest to match new improved error messages - Fixed API_TIMEOUT/UNWRANGLE_TIMEOUT error types in test - All tests now pass successfully
- Fixed test expectations for new timeout error messages - Updated error types array structure test for API_TIMEOUT - All tests now pass with improved timeout handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Timeout Issues and Add Production Error Monitoring
Addresses recurring
cURL error 28timeout failures with the Unwrangle API and adds proactive error monitoring.What's Fixed
Key Changes
AlertServicewithPushoverChannelintegrationImpact
Transforms timeout failures from user-facing errors into proactively monitored events.