Fix Plot2d as PlotLosses output (issue #137)#151
Merged
Conversation
Closed
BaseSubplot now implements set_output_mode, so Plot2d (and siblings) no longer raise AttributeError when passed as a PlotLosses output. Plot2d.send manages its own figure/axes and clears between sends instead of stacking contour/scatter layers each epoch. Notebook vs script mode is honoured via a shared _present helper. Plot2d.send also calls self.predict, so the example notebook's plot2d.predict = plot2d._predict_pytorch monkey-patch (and any user override) actually takes effect. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stared
force-pushed
the
fix-i137-set-output-mode
branch
from
a627f9e to
53d1479
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseSubplot now implements set_output_mode, so Plot2d (and siblings) no longer raise AttributeError when passed as a PlotLosses output.
Plot2d.send manages its own figure/axes and clears between sends instead of stacking contour/scatter layers each epoch. Notebook vs script mode is honoured via a shared _present helper.
Plot2d.send also calls self.predict, so the example notebook's plot2d.predict = plot2d._predict_pytorch monkey-patch (and any user override) actually takes effect.