Remove datastar_response decorator for FastAPI and document replacement#44
Open
gazpachoking wants to merge 1 commit intodevelopfrom
Open
Remove datastar_response decorator for FastAPI and document replacement#44gazpachoking wants to merge 1 commit intodevelopfrom
gazpachoking wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
datastar_responsedecorator stopped working in recent versions of FastAPI. I'm not sure how to best implement it anymore due to the way FastAPI is inspecting the route function to support the new streaming generator syntax. However... the changes in FastAPI that broke the decorator also enable the same functionality by just declaringresponse_class=DatastarResponeseon the route decorator, so I think it's probably okay to just dropdatastar_responsefrom that module.I guess the open issue is just if people are stuck on older versions of FastAPI. Are there such people using the SDK that will be negatively impacted by this?