Skip to content

Conversation

@tatu-at-datastax
Copy link
Contributor

What this PR does:

Removes old "v1" error types: ErrorCodeV1 and JsonApiException, along with remaining references

Which issue(s) this PR fixes:
Fixes #2379

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 50.06%
This PR 50.27%
Delta 🟢 +0.22%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Unit Test Coverage Report

Overall Project 50.27% 🍏
Files changed 100% 🍏

File Coverage
DeleteCollectionOperation.java 98.88% 🍏
CommandErrorFactory.java 97.85% 🍏
NoOptionsCommand.java 97.56% 🍏
ErrorTemplate.java 94.91% 🍏
EmbeddingProviderResponseValidation.java 90.11% 🍏
PathMatchLocator.java 87.71% 🍏
JsonUtil.java 86.99% 🍏
ExceptionMetrics.java 86.36% 🍏
DocumentId.java 79.77% 🍏
EmbeddingProvider.java 71.86% 🍏
DataVectorizer.java 51.21% 🍏
CommandObjectMapperHandler.java 26.17% 🍏
CollectionRerankDef.java 23.44% 🍏
CreateCollectionCommandResolver.java 0% 🍏
VectorizeConfigValidator.java 0% 🍏
CommandProcessor.java 0% 🍏
FrameworkExceptionMapper.java 0% 🍏
EmbeddingTask.java 0% 🍏
RerankingProviderResponseValidation.java 0% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 70.43%
This PR 70.72%
Delta 🟢 +0.30%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 70.72% 🍏
Files changed 100% 🍏

File Coverage
NoOptionsCommand.java 100% 🍏
CommandObjectMapperHandler.java 98.66% 🍏
CreateCollectionCommandResolver.java 97.7% 🍏
DeleteCollectionOperation.java 95.74% 🍏
VectorizeConfigValidator.java 88.83% 🍏
FrameworkExceptionMapper.java 88.65% 🍏
JsonUtil.java 86.6% 🍏
ExceptionMetrics.java 86.36% 🍏
CollectionRerankDef.java 80.75% 🍏
CommandErrorFactory.java 79.57% 🍏
CommandProcessor.java 75.93% 🍏
PathMatchLocator.java 72.73% 🍏
DocumentId.java 62.5% 🍏
ErrorTemplate.java 59.26% 🍏
EmbeddingTask.java 53.14% 🍏
EmbeddingProvider.java 41.21% 🍏
DataVectorizer.java 40.02% 🍏
EmbeddingProviderResponseValidation.java 25.27% 🍏
RerankingProviderResponseValidation.java 0% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.17%
This PR 72.48%
Delta 🟢 +0.31%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 72.48% 🍏
Files changed 100% 🍏

File Coverage
NoOptionsCommand.java 100% 🍏
CommandObjectMapperHandler.java 98.66% 🍏
CreateCollectionCommandResolver.java 97.95% 🍏
DeleteCollectionOperation.java 95.74% 🍏
VectorizeConfigValidator.java 88.83% 🍏
FrameworkExceptionMapper.java 88.65% 🍏
JsonUtil.java 86.6% 🍏
ExceptionMetrics.java 86.36% 🍏
CollectionRerankDef.java 81.04% 🍏
CommandErrorFactory.java 79.57% 🍏
CommandProcessor.java 75.93% 🍏
PathMatchLocator.java 72.73% 🍏
DocumentId.java 62.5% 🍏
ErrorTemplate.java 59.26% 🍏
EmbeddingTask.java 53.14% 🍏
EmbeddingProvider.java 41.21% 🍏
DataVectorizer.java 40.02% 🍏
EmbeddingProviderResponseValidation.java 25.27% 🍏
RerankingProviderResponseValidation.java 16.47% 🍏

@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review February 9, 2026 17:01
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner February 9, 2026 17:01
@tatu-at-datastax tatu-at-datastax merged commit 9d35aaa into main Feb 9, 2026
3 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/2379-rm-errorcodev1-jsonapiexception branch February 9, 2026 21:08
amorton added a commit that referenced this pull request Feb 10, 2026
the work in #2380 was to replace old with new error, this
tidies a couple of things up
@amorton amorton mentioned this pull request Feb 10, 2026
4 tasks
amorton added a commit that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove now-obsolete ErrorCodeV1, JsonApiException

2 participants