Skip to content

Fix #2423: bad error for reranking wrt disabled lexical#2455

Merged
tatu-at-datastax merged 4 commits intomainfrom
tatu/2423-reranking-lexical-error
Apr 21, 2026
Merged

Fix #2423: bad error for reranking wrt disabled lexical#2455
tatu-at-datastax merged 4 commits intomainfrom
tatu/2423-reranking-lexical-error

Conversation

@tatu-at-datastax
Copy link
Copy Markdown
Contributor

What this PR does:

Improves reranking error handling wrt "lexical" field

Which issue(s) this PR fixes:
Fixes #2423

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner April 21, 2026 17:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 49.77%
This PR 49.79%
Delta 🟢 +0.02%
✅ Coverage improved!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Unit Test Coverage Report

Overall Project 49.79% 🍏
Files changed 100% 🍏

File Coverage
CollectionRerankDef.java 24.57% 🍏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.04%
This PR 74.04%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 74.04% 🍏
Files changed 100% 🍏

File Coverage
CollectionRerankDef.java 81.18% 🍏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.66%
This PR 72.66%
Delta 🟢 +0.01%
✅ Coverage improved!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 72.66% 🍏
Files changed 100% 🍏

File Coverage
CollectionRerankDef.java 80.89% 🍏

Copy link
Copy Markdown

@erichare erichare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tatu-at-datastax tatu-at-datastax merged commit c7b6fdb into main Apr 21, 2026
3 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/2423-reranking-lexical-error branch April 21, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data API with lexical/analyzer off does not accept explicit "enabled: false" setting for collections

2 participants