-
Notifications
You must be signed in to change notification settings - Fork 24
Implement #2459 (https://github.com/stargate/data-api/issues/2459): allow overrides for "findAndRerank" command #2460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tatu-at-datastax
wants to merge
18
commits into
main
Choose a base branch
from
tatu/2459-find-and-rerank-override
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a66df30
Implement #2459: allow overrides for "findAndRerank" command
tatu-at-datastax 55216df
Add block of DEPRECATED model overrides
tatu-at-datastax 3df34e8
Config passing clean up
tatu-at-datastax 5d43561
Change to coerce blank Strings to nulls for options
tatu-at-datastax f2bdfa3
Extract helper method
tatu-at-datastax fd060f9
Further correctness fixes
tatu-at-datastax 51e58a9
Unify empty/missing value handling
tatu-at-datastax 361c726
Rework based on clarified definition (update issue description).
tatu-at-datastax 1f72f78
Minor comment improvement
tatu-at-datastax 2dcff8c
Streamlining
tatu-at-datastax 930f015
Minor reordering of validation
tatu-at-datastax 743fd15
Add unit tests
tatu-at-datastax 5d705e9
Add basic ITs as well
tatu-at-datastax ddec95c
Moar testing
tatu-at-datastax bcdfa46
Improve ITs
tatu-at-datastax 1eae708
Simplify tests
tatu-at-datastax b6afdc2
Fix failing IT
tatu-at-datastax f2afee0
Remove unused helper method
tatu-at-datastax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.