Update providers.yml #144
Closed
Update providers.yml #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggesting adding in missing NSXT provider
ilons
reviewed
Feb 18, 2021
Collaborator
ilons
left a comment
ilons
left a comment
There was a problem hiding this comment.
Adding this should also mean generating the bindings for it and checking them in.
However it seems that some cleanup are required (there is a diff when one generates the bindings on develop), and I also think the binding generation script is long overdue for an overhaul.
If you feel like giving it a go to generate the bindings too, the makecode.py is used for this. I'm afraid there is no proper documentation on the process tho 👎
Closed
Collaborator
|
I added this in https://github.com/mjuenema/python-terrascript/pull/158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting adding in missing NSXT provider