Skip to content

Conversation

@LandauRaz
Copy link
Collaborator

@LandauRaz LandauRaz commented Nov 21, 2024

Description of the Changes

Added details for staking on mainnet.

PR Preview URL

Check List

  • Changes made against main branch and PR does not conflict
  • PR title is meaningful, e.g: fix: minor typos in README
  • Detailed description added under "Description of the Changes"
  • Specific URL(s) added under "PR Preview URL"

@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1425/ .

@natan-granit
Copy link
Collaborator

Overall looks much better, thank you for the changes!
2 comments:

  1. Can you have the other procedure consistent with the Becoming a validator, that you have made much better?
  2. On becoming a validator (2nd link), where is the information about the wallets or how to open a starknet account?
  3. WDYT of saying approve instead of pre-approve?

@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1425/ .

2 similar comments
@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1425/ .

@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1425/ .

@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1425/ .

1 similar comment
@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1425/ .

@LandauRaz LandauRaz merged commit 1b7e450 into main Nov 25, 2024
1 check passed
@LandauRaz LandauRaz deleted the staking-launch branch November 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants