Skip to content

Conversation

@qvkare
Copy link
Contributor

@qvkare qvkare commented Dec 27, 2024

Description of the Changes

Updated source code language tags in contract-storage.adoc to correctly identify Cairo code blocks. This change improves documentation accuracy and syntax highlighting.

This PR fixes issue (#1463)

Changes made:

  • Changed [source,js] to [source,cairo]
  • Changed [source,javascript] to [source,cairo]
  • No content modifications were made to preserve the original documentation

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-1464/architecture-and-concepts/smart-contracts/contract-storage/

Check List

  • Changes made against main branch and PR does not conflict
  • PR title is meaningful, e.g: fix: minor typos in README
  • Detailed description added under "Description of the Changes"
  • Specific URL(s) added under "PR Preview URL"

Closes #1463

@starknet-bot
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1464/ .

@LandauRaz LandauRaz self-requested a review December 29, 2024 09:22
@LandauRaz LandauRaz merged commit 4a42d7b into starknet-io:main Dec 29, 2024
1 check passed
@LandauRaz
Copy link
Collaborator

Thanks for the contribution @qvkare!
One small comment: please try to add the entire specific URL(s) for under "PR Preview URL" (I did it for you this time 🙂)

LandauRaz added a commit that referenced this pull request Feb 4, 2025
* Update overview.adoc

* codereview

* codereview cont

* typo fix

* Update nav_glossary.adoc

* New "Resources" section (#1395)

* created resources section

* Update nav.adoc

* Update nav.adoc

* Update nav_glossary.adoc

* Update nav_glossary.adoc

* Update nav.adoc

* Update nav.adoc

* transactions: fix how invoke transaction v3 hash is calculated (#1460)

* fix: source code tips contract-storage.adoc (#1464)

* Update compiled-class-hash.adoc (#1462)

Remove the redundant word

* docs: add Keccak syscall documentation (#1461)

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Setting up account refactor (#1469)

* init

* finish

* minor fixes

* minor fixes

* minor fix

* minor fix

* minor fix

* Replace .sierra.json reference with .contract_class.json (#1470)

Replace old references to <CONTRACT_NAME>.sierra.json with the newer <CONTRACT_NAME>.contract_class.json. This aligns the documentation with the current compiler output and helps first-time users avoid confusion when locating contract artifacts

* fix: cairo-builtins.adoc (#1467)

* Changing the repo link in the overview.adoc (#1471)

* Changing the repo link in the overview.adoc

* Update overview.adoc

---------

Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>

* fix(environment-setup): set `scarb` version first (#1472)

If you try `--version` before you tell `asdf` which version to use, you
get an error:

```
No version is set for command scarb
Consider adding one of the following versions in your config file at
scarb 2.9.2
```

* Validator survey important block (#1473)

* added important block

* Update entering-staking.adoc

* finish (#1476)

* Update .htaccess

* invoke rebuild

* invoked rebuild

* Update push.yml

* Update PULL_REQUEST_TEMPLATE.md

* v0.13.4 pre-release notes (#1482)

* init&finish

* typo fix

* invoke rebuild

* init&finish (#1483)

* init&finish (#1485)

* Devtools refactor (#1475)

* init

* cont

* typo fix

* invoke rebuild

* minor fix

* v2

* cont

* minor fix

* minor fixes

* added-stark-utils

* typo fix

* init&finish (#1487)

* Quickstart refactor (#1480)

* init

* cont

* cont

* cont

* cont

* typo fixes

* minor fix

* minor fix

* cont

* typo fixes

* typo fixes

* minor fix

* minor fix

* minor fix

* minor fix

* estevan-review

* cont

* finish?

* minor fixes

* minor fixes

* minor fixes

* codereview

* nav-restruct

* Update next-steps.adoc

* auditors refactor

* Update version-notes.adoc

* init&finish (#1492)

* Added bug bounty program

* init&finish (#1494)

* Ecosystem security platforms (#1495)

* init&finish

* Update audit.adoc

* Update .htaccess

* Fix typo in environment setup (#1496)

Fix a typo in setup docs

* Overview Refactor (#1498)

* init&finish

* Update index.adoc

* Update README.adoc

* codereview cont

* final changes

* Update overview.adoc

---------

Co-authored-by: razlandau <raz@starkware.co>
Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>
Co-authored-by: ptisserand <p.tisserand@gmail.com>
Co-authored-by: Qvkare <qvkare@gmail.com>
Co-authored-by: Pandit Dhamdhere <85685981+panditdhamdhere@users.noreply.github.com>
Co-authored-by: Nityam Tripathi <100020368+Nityam573@users.noreply.github.com>
Co-authored-by: Silvio Rainoldi <ianaz90@gmail.com>
Co-authored-by: Julio <30329843+julio4@users.noreply.github.com>
Co-authored-by: natan-granit <142514246+natan-granit@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Pam S <pamela.selle@gmail.com>
LandauRaz added a commit that referenced this pull request Feb 4, 2025
* Update overview.adoc

* codereview

* codereview cont

* typo fix

* Update nav_glossary.adoc

* New "Resources" section (#1395)

* created resources section

* Update nav.adoc

* Update nav.adoc

* Update nav_glossary.adoc

* Update nav_glossary.adoc

* Update nav.adoc

* Update nav.adoc

* transactions: fix how invoke transaction v3 hash is calculated (#1460)

* fix: source code tips contract-storage.adoc (#1464)

* Update compiled-class-hash.adoc (#1462)

Remove the redundant word

* docs: add Keccak syscall documentation (#1461)

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Setting up account refactor (#1469)

* init

* finish

* minor fixes

* minor fixes

* minor fix

* minor fix

* minor fix

* Replace .sierra.json reference with .contract_class.json (#1470)

Replace old references to <CONTRACT_NAME>.sierra.json with the newer <CONTRACT_NAME>.contract_class.json. This aligns the documentation with the current compiler output and helps first-time users avoid confusion when locating contract artifacts

* fix: cairo-builtins.adoc (#1467)

* Changing the repo link in the overview.adoc (#1471)

* Changing the repo link in the overview.adoc

* Update overview.adoc

---------

Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>

* fix(environment-setup): set `scarb` version first (#1472)

If you try `--version` before you tell `asdf` which version to use, you
get an error:

```
No version is set for command scarb
Consider adding one of the following versions in your config file at
scarb 2.9.2
```

* Validator survey important block (#1473)

* added important block

* Update entering-staking.adoc

* finish (#1476)

* Update .htaccess

* invoke rebuild

* invoked rebuild

* Update push.yml

* Update PULL_REQUEST_TEMPLATE.md

* v0.13.4 pre-release notes (#1482)

* init&finish

* typo fix

* invoke rebuild

* init&finish (#1483)

* init&finish (#1485)

* Devtools refactor (#1475)

* init

* cont

* typo fix

* invoke rebuild

* minor fix

* v2

* cont

* minor fix

* minor fixes

* added-stark-utils

* typo fix

* init&finish (#1487)

* Quickstart refactor (#1480)

* init

* cont

* cont

* cont

* cont

* typo fixes

* minor fix

* minor fix

* cont

* typo fixes

* typo fixes

* minor fix

* minor fix

* minor fix

* minor fix

* estevan-review

* cont

* finish?

* minor fixes

* minor fixes

* minor fixes

* codereview

* nav-restruct

* Update next-steps.adoc

* auditors refactor

* Update version-notes.adoc

* init&finish (#1492)

* Added bug bounty program

* init&finish (#1494)

* Ecosystem security platforms (#1495)

* init&finish

* Update audit.adoc

* Update .htaccess

* Fix typo in environment setup (#1496)

Fix a typo in setup docs

* Overview Refactor (#1498)

* init&finish

* Update index.adoc

* Update README.adoc

* codereview cont

* final changes

* Update overview.adoc

---------

Co-authored-by: razlandau <raz@starkware.co>
Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>
Co-authored-by: ptisserand <p.tisserand@gmail.com>
Co-authored-by: Qvkare <qvkare@gmail.com>
Co-authored-by: Pandit Dhamdhere <85685981+panditdhamdhere@users.noreply.github.com>
Co-authored-by: Nityam Tripathi <100020368+Nityam573@users.noreply.github.com>
Co-authored-by: Silvio Rainoldi <ianaz90@gmail.com>
Co-authored-by: Julio <30329843+julio4@users.noreply.github.com>
Co-authored-by: natan-granit <142514246+natan-granit@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Pam S <pamela.selle@gmail.com>
LandauRaz added a commit that referenced this pull request Feb 4, 2025
* Update architecture.adoc 

This PR includes all the changes to StarkGate's architecture page.

* Update compiled-class-hash.adoc (#1462)

Remove the redundant word

* docs: add Keccak syscall documentation (#1461)

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Setting up account refactor (#1469)

* init

* finish

* minor fixes

* minor fixes

* minor fix

* minor fix

* minor fix

* Replace .sierra.json reference with .contract_class.json (#1470)

Replace old references to <CONTRACT_NAME>.sierra.json with the newer <CONTRACT_NAME>.contract_class.json. This aligns the documentation with the current compiler output and helps first-time users avoid confusion when locating contract artifacts

* fix: cairo-builtins.adoc (#1467)

* Changing the repo link in the overview.adoc (#1471)

* Changing the repo link in the overview.adoc

* Update overview.adoc

---------

Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>

* fix(environment-setup): set `scarb` version first (#1472)

If you try `--version` before you tell `asdf` which version to use, you
get an error:

```
No version is set for command scarb
Consider adding one of the following versions in your config file at
scarb 2.9.2
```

* Validator survey important block (#1473)

* added important block

* Update entering-staking.adoc

* finish (#1476)

* Update .htaccess

* invoke rebuild

* invoked rebuild

* Update push.yml

* Update PULL_REQUEST_TEMPLATE.md

* v0.13.4 pre-release notes (#1482)

* init&finish

* typo fix

* invoke rebuild

* init&finish (#1483)

* init&finish (#1485)

* Devtools refactor (#1475)

* init

* cont

* typo fix

* invoke rebuild

* minor fix

* v2

* cont

* minor fix

* minor fixes

* added-stark-utils

* typo fix

* init&finish (#1487)

* Quickstart refactor (#1480)

* init

* cont

* cont

* cont

* cont

* typo fixes

* minor fix

* minor fix

* cont

* typo fixes

* typo fixes

* minor fix

* minor fix

* minor fix

* minor fix

* estevan-review

* cont

* finish?

* minor fixes

* minor fixes

* minor fixes

* codereview

* nav-restruct

* Update next-steps.adoc

* auditors refactor

* Update version-notes.adoc

* init&finish (#1492)

* Added bug bounty program

* init&finish (#1494)

* Ecosystem security platforms (#1495)

* init&finish

* Update audit.adoc

* Update .htaccess

* Fix typo in environment setup (#1496)

Fix a typo in setup docs

* Overview Refactor (#1498)

* init&finish

* Update index.adoc

* Update README.adoc

* Update audit.adoc (#1376)

Adding CODESPECT - a newly established company providing Solidity, Cairo and Rust audits.

* Update _typos.toml

* Auditors mini-refactor (#1500)

* init&finish

* Update audit.adoc

* "StarkGate bridge overview" page update (#1458)

* Update overview.adoc

* codereview

* codereview cont

* typo fix

* Update nav_glossary.adoc

* New "Resources" section (#1395)

* created resources section

* Update nav.adoc

* Update nav.adoc

* Update nav_glossary.adoc

* Update nav_glossary.adoc

* Update nav.adoc

* Update nav.adoc

* transactions: fix how invoke transaction v3 hash is calculated (#1460)

* fix: source code tips contract-storage.adoc (#1464)

* Update compiled-class-hash.adoc (#1462)

Remove the redundant word

* docs: add Keccak syscall documentation (#1461)

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc

* Setting up account refactor (#1469)

* init

* finish

* minor fixes

* minor fixes

* minor fix

* minor fix

* minor fix

* Replace .sierra.json reference with .contract_class.json (#1470)

Replace old references to <CONTRACT_NAME>.sierra.json with the newer <CONTRACT_NAME>.contract_class.json. This aligns the documentation with the current compiler output and helps first-time users avoid confusion when locating contract artifacts

* fix: cairo-builtins.adoc (#1467)

* Changing the repo link in the overview.adoc (#1471)

* Changing the repo link in the overview.adoc

* Update overview.adoc

---------

Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>

* fix(environment-setup): set `scarb` version first (#1472)

If you try `--version` before you tell `asdf` which version to use, you
get an error:

```
No version is set for command scarb
Consider adding one of the following versions in your config file at
scarb 2.9.2
```

* Validator survey important block (#1473)

* added important block

* Update entering-staking.adoc

* finish (#1476)

* Update .htaccess

* invoke rebuild

* invoked rebuild

* Update push.yml

* Update PULL_REQUEST_TEMPLATE.md

* v0.13.4 pre-release notes (#1482)

* init&finish

* typo fix

* invoke rebuild

* init&finish (#1483)

* init&finish (#1485)

* Devtools refactor (#1475)

* init

* cont

* typo fix

* invoke rebuild

* minor fix

* v2

* cont

* minor fix

* minor fixes

* added-stark-utils

* typo fix

* init&finish (#1487)

* Quickstart refactor (#1480)

* init

* cont

* cont

* cont

* cont

* typo fixes

* minor fix

* minor fix

* cont

* typo fixes

* typo fixes

* minor fix

* minor fix

* minor fix

* minor fix

* estevan-review

* cont

* finish?

* minor fixes

* minor fixes

* minor fixes

* codereview

* nav-restruct

* Update next-steps.adoc

* auditors refactor

* Update version-notes.adoc

* init&finish (#1492)

* Added bug bounty program

* init&finish (#1494)

* Ecosystem security platforms (#1495)

* init&finish

* Update audit.adoc

* Update .htaccess

* Fix typo in environment setup (#1496)

Fix a typo in setup docs

* Overview Refactor (#1498)

* init&finish

* Update index.adoc

* Update README.adoc

* codereview cont

* final changes

* Update overview.adoc

---------

Co-authored-by: razlandau <raz@starkware.co>
Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>
Co-authored-by: ptisserand <p.tisserand@gmail.com>
Co-authored-by: Qvkare <qvkare@gmail.com>
Co-authored-by: Pandit Dhamdhere <85685981+panditdhamdhere@users.noreply.github.com>
Co-authored-by: Nityam Tripathi <100020368+Nityam573@users.noreply.github.com>
Co-authored-by: Silvio Rainoldi <ianaz90@gmail.com>
Co-authored-by: Julio <30329843+julio4@users.noreply.github.com>
Co-authored-by: natan-granit <142514246+natan-granit@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Pam S <pamela.selle@gmail.com>

* init

---------

Co-authored-by: Pandit Dhamdhere <85685981+panditdhamdhere@users.noreply.github.com>
Co-authored-by: Nityam Tripathi <100020368+Nityam573@users.noreply.github.com>
Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>
Co-authored-by: Silvio Rainoldi <ianaz90@gmail.com>
Co-authored-by: Julio <30329843+julio4@users.noreply.github.com>
Co-authored-by: natan-granit <142514246+natan-granit@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Pam S <pamela.selle@gmail.com>
Co-authored-by: Talfao <46968230+talfao@users.noreply.github.com>
Co-authored-by: razlandau <raz@starkware.co>
Co-authored-by: ptisserand <p.tisserand@gmail.com>
Co-authored-by: Qvkare <qvkare@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect source code language tags in contract-storage.adoc

3 participants