echonet: refactor, remove decoded class, merge functions #10581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 4, 2025
Contributor
Author
This was referenced Dec 4, 2025
matanl-starkware
approved these changes
Dec 4, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
ayeletstarkware
force-pushed
the
ayelet/echonet/refactor/remove-class-log
branch
from
93a96c2 to
5aab15b
Compare
ayeletstarkware
force-pushed
the
ayelet/echonet/refactor/remove-class-decoded
branch
from
f984453 to
6491c75
Compare
graphite-app
bot
changed the base branch from
ayelet/echonet/refactor/remove-class-log
to
graphite-base/10581
ayeletstarkware
force-pushed
the
ayelet/echonet/refactor/remove-class-decoded
branch
from
6491c75 to
0d6224a
Compare
ayeletstarkware
force-pushed
the
graphite-base/10581
branch
from
5aab15b to
b5c1193
Compare
ayeletstarkware
force-pushed
the
ayelet/echonet/refactor/remove-class-decoded
branch
from
0d6224a to
ab815fb
Compare
graphite-app
bot
changed the base branch from
graphite-base/10581
to
main-v0.14.1
Merge activity
|
ayeletstarkware
commented
Dec 7, 2025
Contributor
Author
ayeletstarkware
left a comment
ayeletstarkware
left a comment
There was a problem hiding this comment.
@ayeletstarkware reviewed all commit messages.
Reviewable status:
This was referenced Dec 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.