apollo_staking: implement get_previous_epoch in CairoStakingContract#12902
Open
dafnamatsry wants to merge 1 commit intodafna/mock-staking-get-previous-epoch-datafrom
Open
apollo_staking: implement get_previous_epoch in CairoStakingContract#12902dafnamatsry wants to merge 1 commit intodafna/mock-staking-get-previous-epoch-datafrom
dafnamatsry wants to merge 1 commit intodafna/mock-staking-get-previous-epoch-datafrom
Conversation
|
This change is |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dafnamatsry
force-pushed
the
dafna/apollo-staking-get-previous-epoch
branch
from
2f7280c to
fdb5152
Compare
dafnamatsry
force-pushed
the
dafna/mock-staking-get-previous-epoch-data
branch
from
fabaf19 to
e14599a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds a new on-chain view call and custom retdata parsing for
Option<Epoch>, which could affect epoch selection logic if the contract encoding/entrypoint differs or parsing is incorrect.Overview
Implements
CairoStakingContract::get_previous_epochby calling the newget_previous_epoch_dataentrypoint and deserializing the returned CairoOption<Epoch>.Adds
optional_epoch_from_retdatato decodeSome/Noneepoch responses with stricter length/variant validation, and extends tests to cover defaultNone, successful updates, and error cases.Written by Cursor Bugbot for commit fdb5152. This will update automatically on new commits. Configure here.