starknet_transaction_prover: add deployment health docs and smoke script

[avi-starkware]

Adds three operational artifacts:

• MANUAL_TESTING_GUIDE.md — comprehensive manual testing reference
  (endpoints, negative flows, CORS matrix, compression, concurrency,
  load) for deep deployment validation.

• DEPLOYMENT_SMOKE_TESTING_GUIDE.md — per-deploy 5-10 minute checklist
  covering reachability, core JSON-RPC methods, one real proving flow,
  invalid-request handling, and concurrency protection.

• deployment_smoke.sh — automated smoke script that mirrors the smoke
  guide's checks, prints a PASS/FAIL summary, and supports
  KEEP_ARTIFACTS / TX_HASH / LOOKBACK_BLOCKS overrides for debugging.

[reviewable-StarkWare]

This change is 

[avi-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_transaction_prover: add deployment health docs and smoke script #14052 👈 (View in Graphite)
• starknet_transaction_prover: make RPC error spec test exhaustive via enum #14051
• starknet_transaction_prover: add TLS integration tests #14050
• starknet_transaction_prover: add ServiceConfig validation tests #14049
• starknet_transaction_prover: add CORS validation unit tests #14048
• starknet_transaction_prover: add prover input validation unit tests #14047
• starknet_transaction_prover: add committer utils unit tests #14046
• main-v0.14.3

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Documentation and a bash smoke script only; no runtime or proving logic changes.

Overview
Adds operational deployment validation for starknet_transaction_prover: a short post-deploy smoke checklist, a full manual deep-test reference, and an automated smoke runner.

DEPLOYMENT_SMOKE_TESTING_GUIDE.md defines a 5–10 minute per-deploy gate (reachability, starknet_specVersion, one on-chain INVOKE v3 prove, malformed params, gzip compression, optional TLS/OHTTP, body-size limit, concurrency -32005 + recovery) and points to the manual guide for heavier work.

MANUAL_TESTING_GUIDE.md documents end-to-end manual coverage: happy/negative RPC flows, CORS matrix, compression, concurrency/load (vegeta/hey), TLS, OHTTP, body limits, env-var config, observability, checklist, and a results template.

deployment_smoke.sh implements the smoke guide: requires PROVER_URL / CHAIN_RPC_URL, reads expected spec version from rpc_impl.rs, runs the checks with PASS/FAIL counts, preserves temp artifacts on failure or KEEP_ARTIFACTS=true, and supports TX_HASH, LOOKBACK_BLOCKS, OHTTP_SMOKE, TLS_MIN_DAYS, and MAX_REQUEST_BODY_SIZE.

^{Reviewed by Cursor Bugbot for commit e2aec91. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Stale fallback spec version causes false smoke failures

Medium Severity

The fallback value in || echo "0.10.1" doesn't match the actual SPEC_VERSION constant which is "0.10.2" in rpc_impl.rs. When the grep fails (e.g., the script is copied to a deploy host without the Rust source tree), SPEC_VERSION_EXPECTED becomes "0.10.1", while the running service returns "0.10.2", causing the check_spec_version step to report a false FAIL.

 

^{Reviewed by Cursor Bugbot for commit 8161746. Configure here.}

[cursor]

Concurrency curl calls lack timeout, risking indefinite hang

Low Severity

The three concurrent curl calls in check_concurrency_and_recovery are the only network calls in the script without a --max-time limit. Every other call goes through rpc_call_prover or rpc_call_chain, both of which set --max-time 30. If the prover is slow or unresponsive, the wait loop blocks indefinitely, which is problematic for a script targeting a 5–10 minute runtime and likely used in CI/CD pipelines.

 

^{Reviewed by Cursor Bugbot for commit 8161746. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e2aec91. Configure here.}

[cursor]

Stale fallback spec version causes false failures

Medium Severity

The fallback value "0.10.1" on the grep failure path is stale — the actual SPEC_VERSION in rpc_impl.rs is "0.10.2". When grep -oP fails (e.g. on macOS where -P is unsupported, or when the script is run outside the repo), every spec-version check will incorrectly report FAIL because the expected value doesn't match the deployed service.

 

^{Reviewed by Cursor Bugbot for commit e2aec91. Configure here.}