Skip to content

deployment: wait for node healthcheck before starting the simulator#14225

Open
sirandreww-starkware wants to merge 1 commit into
05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stackfrom
05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator
Open

deployment: wait for node healthcheck before starting the simulator#14225
sirandreww-starkware wants to merge 1 commit into
05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stackfrom
05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 27, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Local docker-compose orchestration only; no runtime application or security logic changes.

Overview
The local monitoring docker-compose stack now treats sequencer nodes as healthy only after port 8081 accepts TCP, using a bash /dev/tcp probe (no curl in the image).

sequencer_simulator no longer starts as soon as sequencer-node-0 is merely up; it waits for service_healthy, avoiding races where the simulator hits the HTTP gateway before it is listening.

Reviewed by Cursor Bugbot for commit 11e78ad. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from 0d4dc26 to 0d4299b Compare May 28, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch from 261a8e1 to 0a0acfb Compare May 28, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from 0d4299b to adf97ec Compare May 28, 2026 09:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch from 0a0acfb to 0c86666 Compare May 28, 2026 09:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from adf97ec to 11e78ad Compare May 28, 2026 11:47
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch from 0c86666 to 8fb59bc Compare May 28, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants