Skip to content

starknet_patricia_storage: move is_gatherable to ReadOnlyStorage#14280

Open
ArielElp wants to merge 1 commit into
ariel/switch_to_blockifier_accessed_keysfrom
ariel/move_as_gatherable_to_read_only_storage
Open

starknet_patricia_storage: move is_gatherable to ReadOnlyStorage#14280
ArielElp wants to merge 1 commit into
ariel/switch_to_blockifier_accessed_keysfrom
ariel/move_as_gatherable_to_read_only_storage

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented Jun 1, 2026

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

ArielElp commented Jun 1, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp force-pushed the ariel/switch_to_blockifier_accessed_keys branch from a4466a7 to a5ac682 Compare June 1, 2026 08:41
@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch from 6209862 to 17d61f2 Compare June 1, 2026 08:41
@ArielElp ArielElp marked this pull request as ready for review June 1, 2026 11:34
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 1, 2026

PR Summary

Low Risk
Trait API relocation with mechanical impl updates; no change to gather semantics or persistence behavior.

Overview
Moves as_gatherable_storage from the Storage trait to ReadOnlyStorage, so callers can detect GatherableStorage support on read-only views without requiring write APIs.

Every backend and wrapper (Aerospike, Mdbx, RocksDB, Map, Cached, Null, ReadsCollector, TwoLayer, ShortKey) now implements the hook on its ReadOnlyStorage impl and drops the duplicate on Storage. Behavior is unchanged: gather-capable stores still return Some(self); wrappers that cannot gather return None.

CachedStorage’s ReadOnlyStorage impl bound is tightened to S: Storage + ImmutableReadOnlyStorage + 'static, matching its GatherableStorage / Storage impls.

Reviewed by Cursor Bugbot for commit 17d61f2. Bugbot is set up for automated code reviews on this repo. Configure here.

@ArielElp ArielElp requested a review from yoavGrs June 1, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants