test(blockifier): refactor account_transaction_test

[TzahiTaub]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-12T12:55:47Z
• Started at 2025-01-12T14:13:01Z

[TzahiTaub]

• test(blockifier): add old cairo 1 to test_initial_gas #3262
• test(blockifier): refactor account_transaction_test #3250 👈 (View in Graphite)
• main-v0.13.4

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @TzahiTaub)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1652 at r1 (raw file):

    let chain_info = &block_context.chain_info;
    let TestInitData { mut state, account_address, contract_address, .. } =
        create_test_init_data(chain_info, CairoVersion::Cairo1(RunnableCairo1::Casm));

the test contract was previously cairo0. don't we need cairo0 coverage here?

Code quote:

    let TestInitData { mut state, account_address, contract_address, .. } =
        create_test_init_data(chain_info, CairoVersion::Cairo1(RunnableCairo1::Casm));

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1745 at r1 (raw file):

    let chain_info = &block_context.chain_info;
    let TestInitData { mut state, account_address, contract_address, .. } =
        create_test_init_data(chain_info, CairoVersion::Cairo1(RunnableCairo1::Casm));

same remark (was cairo0 test contract)

Code quote:

    let TestInitData { mut state, account_address, contract_address, .. } =
        create_test_init_data(chain_info, CairoVersion::Cairo1(RunnableCairo1::Casm));

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1937 at r1 (raw file):

    block_context.versioned_constants.enable_reverts = enable_reverts;
    let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
        create_test_init_data(&block_context.chain_info, cairo_version);

similar comment: I think that even if you are testing a cairo0 contract you would want a cairo1 account for this test

Code quote:

    block_context.versioned_constants.enable_reverts = enable_reverts;
    let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
        create_test_init_data(&block_context.chain_info, cairo_version);

[TzahiTaub]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1652 at r1 (raw file):

Previously, dorimedini-starkware wrote…

the test contract was previously cairo0. don't we need cairo0 coverage here?

It doesn't seem to. This test doesn't check anything about the test contract; it just makes a trivial call to have some base tx.

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1745 at r1 (raw file):

Previously, dorimedini-starkware wrote…

same remark (was cairo0 test contract)

Same as above.

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1937 at r1 (raw file):

Previously, dorimedini-starkware wrote…

similar comment: I think that even if you are testing a cairo0 contract you would want a cairo1 account for this test

This wasn't cairo0, but the account contract was cairo1-casm for the native run, and it will now be native for that run. The address remains the same, it's the same computation for both. This is the TODO @Yoni-Starkware wrote.

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)