-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_api: move HashOutput def #9969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_api: move HashOutput def #9969
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f707680 to
e5d852e
Compare
e5d852e to
9df4271
Compare
|
Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [13.792 ms 13.949 ms 14.113 ms] change: [-6.0530% -4.6126% -3.0766%] (p = 0.00 < 0.05) Performance has improved. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild |
9df4271 to
c5be32c
Compare
c5be32c to
43a4d95
Compare
9278f9f to
62f4f28
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavGrs reviewed 51 of 51 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)
crates/starknet_api/src/hash.rs line 72 at r1 (raw file):
} impl HashOutput {
Single impl
Suggestion:
impl HashOutput {
pub const ROOT_OF_EMPTY_TREE: Self = Self(Felt::ZERO);crates/starknet_api/src/hash.rs line 73 at r1 (raw file):
impl HashOutput { pub fn from_hex(hex_string: &str) -> Result<Self, FromStrError> {
Consider moving impl_from_hex_for_felt_wrapper to here.
Code quote:
pub fn from_hex(hex_string: &str) -> Result<Self, FromStrError>62f4f28 to
a6e83f3
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yoavGrs)
crates/starknet_api/src/hash.rs line 72 at r1 (raw file):
Previously, yoavGrs wrote…
Single impl
Done.
crates/starknet_api/src/hash.rs line 73 at r1 (raw file):
Previously, yoavGrs wrote…
Consider moving
impl_from_hex_for_felt_wrapperto here.
Added a todo.
3471a64 to
618a1ab
Compare
618a1ab to
bda5575
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavGrs reviewed 10 of 10 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

No description provided.