Feature: Make non-zero exit code available when compiler compile fails by leojonathanoh · Pull Request #7 · startersclan/Compile-SourceScript

leojonathanoh · 2020-04-27T04:33:37Z

Fixes #6

leojonathanoh · 2020-04-27T04:57:52Z

For windows, seems like compile.exe is not producing a non-zero exit code: See job and job

For *nix, Need to find out what went wrong here: job

leojonathanoh · 2020-05-04T06:28:22Z

There's some failed checks.

As discussed in #2 (comment), if we decide to no longer support wrappers compile.exe and compile.sh which do not provide proper exit codes, then in this PR it will be much easier to fix existing failed checks.

joeltimothyoh · 2020-05-04T06:33:54Z

There's some failed checks.

As discussed in #2 (comment), if we decide to no longer support wrappers compile.exe and compile.sh which do not provide proper exit codes, then in this PR it will be much easier to fix existing failed checks.

I'd actually be open adding support for exit codes for when compiler wrapper scripts are invoked, and more so than supporting #2. Should we decide to continue support for invoking compiler wrappers, I'll see how I can contribute to make this feature robust if possible.

…ries in Compile-SourceScript()

…cemod compiler or amxmodx compiler wrapper is used

…nstead

…xmodx compiler or compiler wrapper is used

…Windows sourcemod compiler or compiler wrapper is used

…mod compiler or amxmodx compiler wrapper is used

joeltimothyoh

lgtm. Please review @leojonathanoh

joeltimothyoh · 2020-08-10T15:33:34Z

Pinging @leojonathanoh

…nd preparation of compilation environment

… errors in: compilation via compiler binary and compilation via compiler wrapper

…etect errors in: compilation via compiler binary and compilation via compiler wrapper

…, compile, and compilation cleanup stages to ensure cleanup occurs

joeltimothyoh

lgtm

joeltimothyoh · 2020-09-01T20:32:36Z

Merging.

joeltimothyoh · 2020-09-01T21:38:22Z

Should we do a merge commit or squash merge? @leojonathanoh

leojonathanoh · 2020-09-02T00:03:11Z

either will do

joeltimothyoh · 2020-09-02T00:12:33Z

In terms of OSS workflow and git history? @leojonathanoh

joeltimothyoh · 2020-09-11T17:24:07Z

Pinging @leojonathanoh

leojonathanoh · 2020-09-11T21:32:14Z

i prefer merge commits since it’s more traceable

joeltimothyoh · 2020-09-12T01:04:45Z

Ok but we’ve already begun using squash commits in some other projects. Also release notes would be less readable or understandable. @leojonathanoh

joeltimothyoh · 2020-09-21T09:50:22Z

Merging via a merge commit as discussed with @leojonathanoh.

leojonathanoh self-assigned this Apr 27, 2020

leojonathanoh mentioned this pull request May 4, 2020

Add optional param to specify scripting directory #2

Closed

joeltimothyoh force-pushed the fix-exit-with-non-zero-exit-code-when-compile-fails branch from 2143301 to e6fb4e0 Compare August 3, 2020 12:59

leojonathanoh and others added 5 commits August 3, 2020 21:45

Populate the $global:LASTEXITCODE with exit code of compiler

a0c6edc

Fix integration tests to use $global:LASTEXITCODE

86982b1

Add integration tests: bad cases

4af9c66

Fix integrated test bad plugin scenario titles and parameters

6ef6ed0

Fix contamination in stdout stream from creation of temporary directo…

e1fe437

…ries in Compile-SourceScript()

joeltimothyoh force-pushed the fix-exit-with-non-zero-exit-code-when-compile-fails branch from e6fb4e0 to e1fe437 Compare August 3, 2020 13:49

joeltimothyoh added 2 commits August 3, 2020 22:54

Revise to return exit code 1 on plugin compilation failures when sour…

3a06f36

…cemod compiler or amxmodx compiler wrapper is used

Revise integration test scenarios for amxmodx to expect exit code 1 i…

1c50592

…nstead

joeltimothyoh force-pushed the fix-exit-with-non-zero-exit-code-when-compile-fails branch from 1c50592 to 3a06f36 Compare August 3, 2020 15:29

joeltimothyoh added 7 commits August 3, 2020 23:41

Fix integrated test 'Compile plugin via wrapper, bad plugin' scenario

c1831d2

Revise to return an exit code on plugin compilation errors whether am…

ff0ac21

…xmodx compiler or compiler wrapper is used

Revise to return exit code 1 on plugin compilation failures when non-…

08f2914

…Windows sourcemod compiler or compiler wrapper is used

Fix displaying of compile and compiler wrapper stdout for when source…

3c0227a

…mod compiler or amxmodx compiler wrapper is used

Fix sourcemod plugin compilation error regex pattern

c7f6bf5

Tweak debug line for expected exit code and exit code

4c9e880

Rename expected exit code variable for improved clarity

0b76d30

joeltimothyoh self-requested a review August 3, 2020 17:25

joeltimothyoh reviewed Aug 3, 2020

View reviewed changes

joeltimothyoh added feature fix labels Aug 3, 2020

leojonathanoh commented Aug 10, 2020

View reviewed changes

Comment thread src/Compile-SourceScript/Public/Compile-SourceScript.ps1 Outdated

Comment thread src/Compile-SourceScript/Public/Compile-SourceScript.ps1

Comment thread test/scripts/integration/Run-IntegrationTests.ps1

Comment thread test/scripts/integration/Run-IntegrationTests.ps1

joeltimothyoh reviewed Aug 10, 2020

View reviewed changes

Comment thread src/Compile-SourceScript/Public/Compile-SourceScript.ps1

Refactor: Improve code flow in generation of command line arguments a…

b77e9cf

…nd preparation of compilation environment

leojonathanoh force-pushed the fix-exit-with-non-zero-exit-code-when-compile-fails branch from 8fcff17 to b77e9cf Compare August 10, 2020 23:24

Refactor: Match compiler-emitted stdout against error regex to detect…

5f4dceb

… errors in: compilation via compiler binary and compilation via compiler wrapper

leojonathanoh force-pushed the fix-exit-with-non-zero-exit-code-when-compile-fails branch from 35d5c97 to 5f4dceb Compare August 11, 2020 00:16

leojonathanoh added 2 commits August 11, 2020 00:35

Refactor: Cleanup stdinFile immediately after compilation

baf0dce

Refactor: Enhance regex to match compiler-emitted stdout against to d…

d9751aa

…etect errors in: compilation via compiler binary and compilation via compiler wrapper

leojonathanoh force-pushed the fix-exit-with-non-zero-exit-code-when-compile-fails branch from 086fd6e to d9751aa Compare August 11, 2020 01:16

Refactor: Enhance integration test descriptions for good plugins

eff914f

joeltimothyoh reviewed Aug 11, 2020

View reviewed changes

Comment thread src/Compile-SourceScript/Public/Compile-SourceScript.ps1 Outdated

joeltimothyoh reviewed Aug 11, 2020

View reviewed changes

Comment thread src/Compile-SourceScript/Public/Compile-SourceScript.ps1 Outdated

leojonathanoh added 2 commits August 31, 2020 04:32

Refactor: Print stderr of compilation after stdout of compilation

fb8517a

Fix: Add try catch finally around compilation environment preparation…

d3f8694

…, compile, and compilation cleanup stages to ensure cleanup occurs

leojonathanoh requested a review from joeltimothyoh August 31, 2020 04:50

joeltimothyoh approved these changes Sep 1, 2020

View reviewed changes

joeltimothyoh changed the title ~~Make non-zero exit code available when compiler compile fails~~ Feature: Make non-zero exit code available when compiler compile fails Sep 21, 2020

joeltimothyoh merged commit fe8a900 into startersclan:master Sep 21, 2020

joeltimothyoh added this to the v2.1.0 milestone Sep 22, 2020

Conversation

leojonathanoh commented Apr 27, 2020

Uh oh!

leojonathanoh commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leojonathanoh commented May 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joeltimothyoh commented May 4, 2020

Uh oh!

joeltimothyoh left a comment

Choose a reason for hiding this comment

Uh oh!

joeltimothyoh commented Aug 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joeltimothyoh left a comment

Choose a reason for hiding this comment

Uh oh!

joeltimothyoh commented Sep 1, 2020

Uh oh!

joeltimothyoh commented Sep 1, 2020

Uh oh!

leojonathanoh commented Sep 2, 2020

Uh oh!

joeltimothyoh commented Sep 2, 2020

Uh oh!

joeltimothyoh commented Sep 11, 2020

Uh oh!

leojonathanoh commented Sep 11, 2020

Uh oh!

joeltimothyoh commented Sep 12, 2020

Uh oh!

joeltimothyoh commented Sep 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leojonathanoh commented Apr 27, 2020 •

edited

Loading

leojonathanoh commented May 4, 2020 •

edited

Loading