-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/join start #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/join start #87
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
824f0d3
join page
ValentinAhrend 7836339
finalize
ValentinAhrend 216a85c
fix
ValentinAhrend b67c260
changes and new images
ValentinAhrend d97b242
Merge branch 'main' into feat/join-start
ValentinAhrend 22f0168
time switch
ValentinAhrend af42e6d
fix
ValentinAhrend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| /// <reference path="./.next/types/routes.d.ts" /> | ||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/app/api-reference/config/typescript for more information. | ||
| // see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
git ls-files app/home/ app/join-start/ | head -20Repository: startmunich/website-special-pages
Length of output: 187
🏁 Script executed:
Repository: startmunich/website-special-pages
Length of output: 174
🏁 Script executed:
Repository: startmunich/website-special-pages
Length of output: 168
🏁 Script executed:
Repository: startmunich/website-special-pages
Length of output: 1664
🏁 Script executed:
Repository: startmunich/website-special-pages
Length of output: 743
Stabilize the launch gate across render and hydration cycles.
The
Date.now()check on line 158 runs during render, causing the CTA visibility to depend on when the cached homepage HTML was produced. This creates a hydration mismatch on the client around April 10, 2026, where prerendered HTML and the hydrated tree may disagree. The timestamp is also duplicated inapp/join-start/2026/JoinStartClient.tsx:8, creating maintenance risk if the launch date changes.Suggested fix
Extract the timestamp to a shared constant and gate the render on hydration completion:
This ensures the CTA only appears after the client hydrates, eliminating the mismatch window.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, ich approve mal, aber schau dir trotzdem das evtl noch mal an
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 1085
@SimonBurmerDanke! Die beiden Punkte aus meinem ursprünglichen Review sind tatsächlich noch offen:1. Hydration mismatch (HomeClient.tsx, Line 158)
loadedwird bereits in derclassNamedes Buttons verwendet (Line 161), aber nicht in der Render-Bedingung selbst. Das bedeutet der Server rendert den Button basierend auf dem Build-Zeitpunkt, der Client hydratisiert aber zum tatsächlichen Aufruf-Zeitpunkt — das kann kurz um den 10. April zu Inkonsistenzen führen:2. Dupliziertes Datum
JoinStartClient.tsxdefiniert bereitsconst LAUNCH_DATE = new Date('2026-04-10T00:00:00+02:00').getTime()(Line 8), aberHomeClient.tsxdupliziert denselben Wert inline. Empfehlung: die Konstante in eine geteilte Datei auslagern, z.B.:Und dann in beide Komponenten importieren:
Da der 10. April bereits vorbei ist und der Button dauerhaft sichtbar ist, ist der Hydration-Bug jetzt weniger kritisch — aber die geteilte Konstante bleibt trotzdem sinnvoll für Wartbarkeit.