Skip to content

important changes#93

Merged
niklas1simakov merged 3 commits intomainfrom
fast-changes-please
Apr 9, 2026
Merged

important changes#93
niklas1simakov merged 3 commits intomainfrom
fast-changes-please

Conversation

@ValentinAhrend
Copy link
Copy Markdown
Contributor

@ValentinAhrend ValentinAhrend commented Apr 9, 2026

Summary by CodeRabbit

  • New Features

    • Added external "Register now" links for Founder Fail Tales and Online Info Event.
  • Updates

    • Updated images for events for improved visuals.
    • Removed one event from the displayed events list.
  • Style

    • Refreshed main "Apply" CTA styling and updated label to "Apply Now".

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
start-munich Ready Ready Preview, Comment Apr 9, 2026 11:31pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@ValentinAhrend has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e263293e-6399-4dd0-b5da-94c402b2142a

📥 Commits

Reviewing files that changed from the base of the PR and between c0ad5c8 and e6b539c.

📒 Files selected for processing (1)
  • app/join-start/2026/JoinStartClient.tsx
📝 Walkthrough

Walkthrough

Updated JoinStartClient.tsx: adjusted the main "Apply" CTA button styling and label text, removed the YC Event entry, and replaced images and added external "Register now" links for Founder Fail Tales and Online Info Event.

Changes

Cohort / File(s) Summary
CTA Button
app/join-start/2026/JoinStartClient.tsx
Changed Apply CTA from a rounded inline-block to inline-flex, updated border radius, transition and hover shadow, and changed button label from Apply now to Apply Now.
Event Data Updates
app/join-start/2026/JoinStartClient.tsx
Commented-out/removed the YC Event entry. Updated Founder Fail Tales image to /join-start/founder-fail-tales.png and added an external Register now link. Updated Online Info Event image to /join-start/online-info-2026.png and added an external Register now link.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • Feat/join start #87: Edits the same JoinStartClient.tsx events array and UI, including event entries and assets.

Suggested reviewers

  • SimonBurmer

Poem

🐰 I nibbled code beneath the moonlit glow,
Tweaked a button's bounce and made images show,
One event tucked in for a quiet rest,
Two sprang up bright with "Register now" dressed,
Hop in, click, and let the new pages flow. 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'important changes' is vague and non-descriptive, failing to convey what specific changes were made to the codebase. Use a more specific title that describes the main change, such as 'Update JoinStartClient styling and event configurations' or 'Refresh JoinStartClient button styling and events list'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fast-changes-please

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app/join-start/2026/JoinStartClient.tsx (1)

181-181: Remove commented-out event data from the live array.

Line 181 leaves a disabled object in production code. Prefer deleting it (or moving it to docs/changelog) to avoid accidental reactivation and reduce noise.

Suggested cleanup
-            //{ title: 'YC Event', desc: 'START Munich', date: 'Wednesday, 15th April 2026', time: null, img: '/join-start/yc-event.jpg', link: null, linkLabel: null },
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/join-start/2026/JoinStartClient.tsx` at line 181, Remove the
commented-out event object in JoinStartClient.tsx (the disabled line containing
the YC Event object) from the live events array so it no longer appears in
production code; either delete that line entirely or move the object into a
docs/changelog file for historical reference, and ensure the surrounding array
syntax in the events/props (where the commented object currently sits) remains
valid after removal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/join-start/2026/JoinStartClient.tsx`:
- Line 181: Remove the commented-out event object in JoinStartClient.tsx (the
disabled line containing the YC Event object) from the live events array so it
no longer appears in production code; either delete that line entirely or move
the object into a docs/changelog file for historical reference, and ensure the
surrounding array syntax in the events/props (where the commented object
currently sits) remains valid after removal.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 020b84ff-4a36-4422-9d29-43bf5e70eb88

📥 Commits

Reviewing files that changed from the base of the PR and between 16522a2 and 8ef0f20.

⛔ Files ignored due to path filters (3)
  • public/join-start/founder-fail-tales.png is excluded by !**/*.png
  • public/join-start/info-session-2026.png is excluded by !**/*.png
  • public/join-start/online-info-2026.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • app/join-start/2026/JoinStartClient.tsx

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
app/join-start/2026/JoinStartClient.tsx (2)

181-181: Remove commented-out event entries from the data list.

Line 181 leaves dead config in-place. Prefer deleting the object (or gating it with an explicit flag) instead of commented code in render data.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/join-start/2026/JoinStartClient.tsx` at line 181, Remove the dead
commented-out event object from the events data array in JoinStartClient.tsx
(the commented line containing "{ title: 'YC Event', desc: 'START Munich', ...
}"); either delete that commented entry entirely from the events/data list or
implement an explicit feature flag check (e.g., showYCEvent) and conditionally
include the object in the array instead of leaving it commented out. Update the
events data creation (inside the JoinStartClient component or wherever the
events array is defined) to reflect the removal or the conditional inclusion so
no commented config remains in the render data.

137-144: Use the shared shadcn button pattern for the primary CTA.

Line 137–144 manually styles the CTA anchor; this diverges from the project UI component pattern and can cause style drift. Consider switching to the shared shadcn button (asChild + <a>).

As per coding guidelines, **/*.{tsx,ts} should “Follow shadcn/ui component patterns”.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/join-start/2026/JoinStartClient.tsx` around lines 137 - 144, Replace the
manually-styled anchor with the shared shadcn Button pattern: import Button from
your shared UI (e.g., components/ui/button) and render <Button asChild> wrapping
the existing <a href=... target=... rel=...>Apply Now</a>, moving
href/target/rel onto the inner <a> and removing the manual CTA classes in favor
of Button props (variant/size) or button-level className; update
JoinStartClient.tsx to use the Button component and ensure the import is added.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/join-start/2026/JoinStartClient.tsx`:
- Around line 184-187: The event objects in JoinStartClient.tsx (the array used
to render event cards in JoinStartClient) reuse the generic linkLabel "Register
now" for multiple items (e.g., the objects with title 'Founder Fail Tales' and
'Online Info Event'); update each event object's linkLabel to an event-specific
CTA (e.g., "Register for Founder Fail Tales", "Register for Online Info Event"
or other concise contextual labels) so the rendered CTAs are unique and
descriptive; locate and edit the event entries in the array passed to the
card-rendering code (the objects containing title, desc, date, time, img, link,
linkLabel) and replace the repeated "Register now" values with distinct labels
per event.

---

Nitpick comments:
In `@app/join-start/2026/JoinStartClient.tsx`:
- Line 181: Remove the dead commented-out event object from the events data
array in JoinStartClient.tsx (the commented line containing "{ title: 'YC
Event', desc: 'START Munich', ... }"); either delete that commented entry
entirely from the events/data list or implement an explicit feature flag check
(e.g., showYCEvent) and conditionally include the object in the array instead of
leaving it commented out. Update the events data creation (inside the
JoinStartClient component or wherever the events array is defined) to reflect
the removal or the conditional inclusion so no commented config remains in the
render data.
- Around line 137-144: Replace the manually-styled anchor with the shared shadcn
Button pattern: import Button from your shared UI (e.g., components/ui/button)
and render <Button asChild> wrapping the existing <a href=... target=...
rel=...>Apply Now</a>, moving href/target/rel onto the inner <a> and removing
the manual CTA classes in favor of Button props (variant/size) or button-level
className; update JoinStartClient.tsx to use the Button component and ensure the
import is added.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07e39df3-6e97-4b29-ba29-d1616d8cd2a0

📥 Commits

Reviewing files that changed from the base of the PR and between 8ef0f20 and c0ad5c8.

📒 Files selected for processing (1)
  • app/join-start/2026/JoinStartClient.tsx

Comment on lines +184 to +187
{ title: 'Founder Fail Tales', desc: 'Vol. 5', date: 'Tuesday, 21st April 2026', time: null, img: '/join-start/founder-fail-tales.png', link: 'https://luma.com/fp1fd6qv', linkLabel: 'Register now' },
{ title: 'Why Start? Info Session', desc: 'Real people. Real journeys. Real reasons to START.', date: 'Thursday, 23rd April 2026', time: null, img: '/join-start/info-session-2026.png', link: 'https://luma.com/t5r7vw10', linkLabel: 'Register now' },
{ title: 'Student Initiative Showcase', desc: 'START Munich', date: 'Friday, 24th April 2026', time: null, img: '/join-start/student-club-fair.jpg', link: null, linkLabel: null },
{ title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info.jpg', link: null, linkLabel: null },
{ title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info-2026.png', link: 'https://luma.com/4q4m43v3', linkLabel: 'Register now' },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use event-specific CTA labels for clearer link context.

Line 184 and Line 187 use a generic Register now, which makes repeated CTAs less descriptive in dense card lists. Prefer contextual labels per event.

✏️ Proposed text-only improvement
- { title: 'Founder Fail Tales', desc: 'Vol. 5', date: 'Tuesday, 21st April 2026', time: null, img: '/join-start/founder-fail-tales.png', link: 'https://luma.com/fp1fd6qv', linkLabel: 'Register now' },
+ { title: 'Founder Fail Tales', desc: 'Vol. 5', date: 'Tuesday, 21st April 2026', time: null, img: '/join-start/founder-fail-tales.png', link: 'https://luma.com/fp1fd6qv', linkLabel: 'Register for Founder Fail Tales' },

- { title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info-2026.png', link: 'https://luma.com/4q4m43v3', linkLabel: 'Register now' },
+ { title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info-2026.png', link: 'https://luma.com/4q4m43v3', linkLabel: 'Register for Online Info Event' },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{ title: 'Founder Fail Tales', desc: 'Vol. 5', date: 'Tuesday, 21st April 2026', time: null, img: '/join-start/founder-fail-tales.png', link: 'https://luma.com/fp1fd6qv', linkLabel: 'Register now' },
{ title: 'Why Start? Info Session', desc: 'Real people. Real journeys. Real reasons to START.', date: 'Thursday, 23rd April 2026', time: null, img: '/join-start/info-session-2026.png', link: 'https://luma.com/t5r7vw10', linkLabel: 'Register now' },
{ title: 'Student Initiative Showcase', desc: 'START Munich', date: 'Friday, 24th April 2026', time: null, img: '/join-start/student-club-fair.jpg', link: null, linkLabel: null },
{ title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info.jpg', link: null, linkLabel: null },
{ title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info-2026.png', link: 'https://luma.com/4q4m43v3', linkLabel: 'Register now' },
{ title: 'Founder Fail Tales', desc: 'Vol. 5', date: 'Tuesday, 21st April 2026', time: null, img: '/join-start/founder-fail-tales.png', link: 'https://luma.com/fp1fd6qv', linkLabel: 'Register for Founder Fail Tales' },
{ title: 'Why Start? Info Session', desc: 'Real people. Real journeys. Real reasons to START.', date: 'Thursday, 23rd April 2026', time: null, img: '/join-start/info-session-2026.png', link: 'https://luma.com/t5r7vw10', linkLabel: 'Register now' },
{ title: 'Student Initiative Showcase', desc: 'START Munich', date: 'Friday, 24th April 2026', time: null, img: '/join-start/student-club-fair.jpg', link: null, linkLabel: null },
{ title: 'Online Info Event', desc: 'You are temporarily not in Munich? We got you.', date: 'Friday, 24th April 2026', time: null, img: '/join-start/online-info-2026.png', link: 'https://luma.com/4q4m43v3', linkLabel: 'Register for Online Info Event' },
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/join-start/2026/JoinStartClient.tsx` around lines 184 - 187, The event
objects in JoinStartClient.tsx (the array used to render event cards in
JoinStartClient) reuse the generic linkLabel "Register now" for multiple items
(e.g., the objects with title 'Founder Fail Tales' and 'Online Info Event');
update each event object's linkLabel to an event-specific CTA (e.g., "Register
for Founder Fail Tales", "Register for Online Info Event" or other concise
contextual labels) so the rendered CTAs are unique and descriptive; locate and
edit the event entries in the array passed to the card-rendering code (the
objects containing title, desc, date, time, img, link, linkLabel) and replace
the repeated "Register now" values with distinct labels per event.

- Recompute isLive/isClosed on each tick instead of once
- Show fallback Hero UI instead of blank page before hydration
- Replace nested <main> with <div> to avoid duplicate landmark
- Use Tailwind aspect-video instead of inline padding hack
- Replace inline border style with Tailwind classes
- Remove ineffective px-12 on fill-image container

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@niklas1simakov niklas1simakov merged commit d2e803f into main Apr 9, 2026
3 checks passed
@niklas1simakov niklas1simakov deleted the fast-changes-please branch April 9, 2026 23:33
This was referenced Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants