-
Notifications
You must be signed in to change notification settings - Fork 92
Importer Improvements #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
Statamic 5 Support
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport collections command
…mport globals command Also add tests to cover the globals importer
12 tasks
…tamic/eloquent-driver into fix/add-arguments-to-import-commands
… trait from Core Related: statamic/cms#9871
…ts-to-import-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes various changes around the importer commands. Changes include but are not limited to:
->submissions()relationship on theFormmodel, which was removed in Split forms and form submissions, provide Eloquent Submission Repository and Query Builder #177.Submissionmodel.->toModel(), it was touching was a coreAssetContainerclass which didn't have atoModelclass on it, causing it to be sent through the augmentation stuff and error out.makeModelFromContractmethod to theAssetContainerclass, which seems to be how the new importer implementations work.shouldImport...methods.--only-*arguments to some importers responsible for importing multiple things--only-assetsor--only-form-submissionon importer commands which can import multiple things like importing asset containers & assets or forms & form submissions.This PR started out small but grew arms and legs once I decided to add tests for everything 😆 .
Related: statamic/cms#9669.
To Do
ImportGlobalsTestImportEntriesTest$shouldUseStringEntryIdsproperty doesn't seem to help.Target class [statamic.eloquent.entries.model] does not exist.