Allow blueprints and field sets to be split repository #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmitchell
changed the title
duncanmcclean
requested changes
Jun 17, 2024
duncanmcclean
approved these changes
Jun 17, 2024
jasonvarga
reviewed
Jun 18, 2024
src/ServiceProvider.php
Outdated
| namespace Statamic\Eloquent; | ||
|
|
||
| use Illuminate\Foundation\Console\AboutCommand; | ||
| use JetBrains\PhpStorm\Deprecated; |
There was a problem hiding this comment.
This seems like a mistake. (You started using PhpStorm? 😄 )
There was a problem hiding this comment.
definitely a mistake.
i told you i'd give it a go... i don't hate it as much as i thought i would :)
There was a problem hiding this comment.
i think it added it when i added @deprecated in a comment
|
This is not push-back at all, but I'm just curious why someone would want blueprints in the db and fieldsets in files (and vice-versa). |
|
So the use case for TV2 is form blueprints only in the DB, other blueprints and fieldsets as file. |
|
Ah yeah I remember that conversation. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows blueprints and field sets to be run in split repository mode, ie the blueprints could be eloquent driven and field sets file driven, or vice versa.
It also fixes some of the code introduced in #300 to handle methods that were missed initially.