Fix submission is newly created on save #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#439 potential fix |
Contributor
|
I modified this a little - let me know if it still works for you. |
Contributor
Author
|
Your code change seems to work, but i don't really understand why you would only set the id on save and not always? |
Contributor
|
We only need to set it on first save - after that it gets set by fromModel() |
Contributor
Author
|
Thanks for the explanation. It works for me. |
Contributor
|
Thanks for the PR - appreciate you taking the time to submit it. |
faltjo
pushed a commit
to faltjo/eloquent-driver
that referenced
this pull request
Jun 30, 2025
* Fix submission is newly created on save * Do it on save --------- Co-authored-by: Ryan Mitchell <ryan@thoughtcollective.com>
duncanmcclean
pushed a commit
that referenced
this pull request
Jul 4, 2025
* Fix submission is newly created on save * Do it on save --------- Co-authored-by: Ryan Mitchell <ryan@thoughtcollective.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the id from the model is not passed back to the FileEntry, it will always create a new submission on save
Closes #439